----- Original Message ----- 
From: "James Mitchell" <[EMAIL PROTECTED]>
Sent: Monday, April 04, 2005 1:03 PM


> That's cool.  No worries (see above).  El will be part of the nightlies
> tonight.  Thanks for pointing this out.

Excellent, thanks again :-)

> > The only other thing I noticed was the binary distro unpacks to the
> > "struts-1.2.6" folder. In the past nightlies just unpacked to a "struts"
> > (or
> > jakarta-struts) folder - I don't have a problem with including a version
> > number, but I think 1.2.6 is mis-leading - IMO "struts-1.2.7-nightly" or
> > "struts-nightly" or "struts-20050402" would be better.
>
> That's correct.  The way I am building the nightlies is by running Ant
using
> the "release" target.  So any one of us can change that to whatever we
feel
> is the best name. (I need to tweak my nightly script to either ignore the
> x.y.z part of the name or move the copying to be part of the ant build
since
> I can just build the 'copy from' name the same env.
>
> If you want to make that change, go ahead, I'll see it come across and
I'll
> patch my nightly accordingly.

Currently its constructed from the "project.version" property in the
build.xml and AFAIK in the past thats only been updated when we actually
release a version. Whatever we do with that though, IMO the best thing for
the nightly builds is to override the  "upload.file.base" property in the
build.properties file and set it to "struts-1.2.7-nightly". What do you
think?

I've just noticed something else - the source distro's don't contain the el
taglib source either - and actually the recent 1.2.6 version we distributed
recently didn't. Its because of the SVN migration and moving things like el
out of the head/trunk and into its own separate component. I'll add
something to the 1.2.x build.xml to copy the el source in.

Niall



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to