I agree commons-validator shouldn't have code that mentions Servlets or Struts, but they would benefit from a validator that uses jexl, which I believe isn't tied to servlets (I could be wrong here). If I'm not, why not put the el validator in commons-validator, but add a hook for folks like Struts to add variables in the immediate scope, ala Velocity and Velocity tools.
That sounds like a good approach. But it still leaves us with the question: if a rich JEXL-based validator would be useful in Struts (as in one which can populate the expression evaluation context with Struts-centric or Servlet-centric objects), the where does that go in Struts? At the moment, I have little taste for spawning yet another artifact, especially with no clear idea of what else would go in it.
I take that back. It sounds like a reasonable approach -- but I fear for what it would take to get a new release of commons-validator cut so that we could depend upon it for Struts. I know I should roll up my sleeves, but it's busy season again, so there's no point in pretending I'd have time for that any time soon.
Joe
Don
Joe Germuska wrote:At 5:12 PM -0700 5/10/05, Don Brown wrote:
Actually, the extras I was referring to was for the commons-validator project itself as I mistook the ticket for a validator ticket. The Beanshell and xpath validators required only the commons-validator project and had nothing to do with Struts. Ideally, all validators could be added to the commons-validator project and be immediately reusable in environments like Struts and Spring. Unfortunately, the code is currently too muddled for that so Struts has to create a wrapper for every new validator/validation.
Also, at least in this case, I think one of the strong benefits is the preparation of a meaningful expression evaluation context which includes references to the ActionForm and the request and session scope, etc. commons-validator has no business being bound to the servlet API or the Struts API. (I suppose you could treat the form as a POJO and cover one of those, but not both.)
Joe
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
