Seems like the lists and Gmail are having communication problems -- my Gmail
messages don't seem the reach either list today.  Apologies if this messages
gets to you twice. 

====

Key/value properties were just added last week to config (objects other
than ActionConfig, which already supports inheritance for key-value
properties).  Supporting inheritance for them is next on my plate, and
in fact I'm hoping to get to them today (was unavailable the past
couple of weeks for Struts work).  It will most likely be similar to the
second solution you mentioned.

I'm -1 on copying config instances between elements.  Each config has
had its own instance of related config objects and I wouldn't know
what problems might arise by sharing instances.  We may also have a
hard time keeping track of which instances are being shared and which
are not.  Aside from that, I fear that after sharing instances, we'd
next want to "optimize the config objects by sharing similarly
configured elements declared in struts-config".  Leave me out of that
one.

Hubert


--- Riyaz Mansoor <[EMAIL PROTECTED]> wrote:
> 
> <snip file="FormBeanConfig" method="inheritFormProperties">
> 
> if (prop == null) {
>      // We don't have this, so let's copy it
>      prop = (FormPropertyConfig)RequestUtils
>                    .applicationInstance(baseFpc.getClass().getName());
> 
>      BeanUtils.copyProperties(prop, baseFpc);
>      this.addFormPropertyConfig(prop);
> }
> 
> </snip>
> 
> bug: key/value properties set in "baseFpc" is not copied to "prop"
> 
> sol1: add inline code here
> sol2: add method to BaseConfig to inherit a parentConfig's properties 
> and call from here/above. possible other similar cases in other configs.
> 
> will submit patch, wondering which method is more suitable. ideas?
> 
> ps: i can't understand y a new FormPropertyConfig instance is created 
> :(. can't v just share the propConfig? it is readonly right?
> 
> riyaz
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


                
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Helps protect you from nasty viruses. 
http://promotions.yahoo.com/new_mail

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to