On 5/18/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: > The situation is consistent with previous releases. Contrib was first > included in Struts 1.1 and both the Struts 1.1 and Struts 1.2.4 releases > have only struts-el in the contrib folder of the binary distro - but a > complete copy of the whole of what was in CVS contrib in the source distro.
Well, to be truly consistent, we would have a complete copy of contrib in the 1.2.7 source distribution, then, right? ;-) > The inconsitency was with versions such as 1.2.6 where "contrib" was missing > from the source distro. I did consult on this issue and what should be > included in the source distro "contrib" folder in the following thread > before doing the 1.2.7 release and would be disappointed if that now caused > an issue since people had an opportunity to raise any concerns then. > > http://www.mail-archive.com/[email protected]/msg08968.html > http://www.mail-archive.com/[email protected]/msg08977.html I'm sorry, I completely missed the point in that thread about these changes happening in the source distribution only. When I saw messages such as this one (from the same thread): http://www.mail-archive.com/[email protected]/msg08970.html I just assumed that it was being built, as well as being included with the sources. If I had realised it was only being included in source form, then I would indeed have raised my concerns then. Frankly, I see little reason to include anything in the source distribution that isn't being included, in binary form, in the binary distribution. I suspect that's why we only included the EL sources in 1.2.6, too. Since I only have myself to blame for not reading the thread closely enough, I think I'll step back and let other folks decide what to do with 1.2.7. -- Martin Cooper > Niall > > ----- Original Message ----- > From: "Martin Cooper" <[EMAIL PROTECTED]> > Sent: Wednesday, May 18, 2005 6:30 PM > > We seem to have a slightly odd situation in 1.2.7 with respect to the > inclusion of contrib packages. In the binary distribution, we have > struts-el, while in the source distribution, we have struts-chain, > struts-el and struts-faces. My expectation would have been that > whatever we provide in the source distribution would also be provided > in the binary distribution. > > I can't decide how serious I think this is. On the one hand, it's a > contrib issue, meaning that it shouldn't be that big of a deal. On the > other hand, I feel uneasy with the idea of having a GA release that > has known packaging issues. > > What do other folks think? > > -- > Martin Cooper > > PS - This is the only issue that we (at my day job) have found with > 1.2.7 so far. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
