James, Thanks much for all the cleanup work on Shale ... but this change breaks the build for me. The CommonsValidatorTag class in org.apache.shale.taglib still has "implements Constants".
Craig On 6/10/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: jholmes > Date: Fri Jun 10 11:05:11 2005 > New Revision: 189997 > > URL: http://svn.apache.org/viewcvs?rev=189997&view=rev > Log: > Convert constants classes from interfaces to concrete classes to prevent > accidental variable leak per bug #32341. > > Modified: > struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java > > struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java > > Modified: > struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java > URL: > http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java?rev=189997&r1=189996&r2=189997&view=diff > ============================================================================== > --- struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java > (original) > +++ struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java > Fri Jun 10 11:05:11 2005 > @@ -23,7 +23,11 @@ > * > * $Id$ > */ > -public interface Constants { > +public class Constants { > > + /** > + * <p>Private constructor so that this class cannot be instantiated.</p> > + */ > + private Constants() {} > > } > > Modified: > struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java > URL: > http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java?rev=189997&r1=189996&r2=189997&view=diff > ============================================================================== > --- > struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java > (original) > +++ > struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java > Fri Jun 10 11:05:11 2005 > @@ -16,9 +16,6 @@ > > package org.apache.shale.faces; > > -import org.apache.shale.ViewController; > -import org.apache.shale.ViewControllerMapper; > -import org.apache.shale.util.TokenProcessor; > > /** > * <p>[EMAIL PROTECTED] ShaleConstants} are manifest constants defining > global identifiers shared across > @@ -27,8 +24,13 @@ > * > * $Id$ > */ > -public interface ShaleConstants { > +public class ShaleConstants { > > + /** > + * <p>Private constructor so that this class cannot be instantiated.</p> > + */ > + private ShaleConstants() {} > + > > /** > * <p>Application scope attribute that's an instance of > @@ -39,7 +41,8 @@ > */ > public static final String TAG_UTILITY_BEAN = > "org.apache.shale.TAG_UTILITY_BEAN"; > - > + > + > /** > * <p>Appication scope attribute key under which the > * [EMAIL PROTECTED] TokenProcessor} instance for this application is > stored.</p> > @@ -80,6 +83,4 @@ > */ > public static final String VIEWS_INITIALIZED = > "org.apache.shale.faces.VIEWS_INITIALIZED"; > - > - > } > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
