I would very much like to see this duplicated code feature improved. I think it goes along with good refactoring so if it worked well it would be really helpful. I see way too much duplicated code in the code reviews I have to do.
-- The only problem with doing it right the first time is that no one appreciates how hard it was, the skill, talent and experience required, how long it took, the research required, the experiments involved, the testing to prove it, having it peer reviewed, and finally edited and published. It's a wonder anything works! Ivan S Kirkpatrick, PE home 850 656 9107 cell 253 229 6605 > Frank W. Zammetti said: > > * StrictDuplicateCode > > Duplicate code is just plain bad... not in terms of something not > > working, although that is certainly possible in some > > situations, but > > it's just a sign of carelessness. If nothing else, I'm sure no one > > wants the Struts code base to show any carelessness that > > could easily > > be avoided. > > [snip] > > > > The second is the updated version with all the above checks added... > > this results in 16584 complaints, which is clearly a lot... however, > the > > vast majority of the additional complaints result from the > > StrictDuplicateCode and are probably ignorable, so that's one rule > that > > on second thought maybe shouldn't be added... > > I would say this rule too simpleminded to be usable. I took a quick > look at the output, and it seems that it's complaining about the same > license boilerplate at the top of every file. No wonder it found so > many complaints! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
