DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36714>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36714

           Summary: [shale] AbstractFacesBean message methods don't use the
                    UIComponent parameter
           Product: Struts
           Version: Nightly Build
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Shale
        AssignedTo: dev@struts.apache.org
        ReportedBy: [EMAIL PROTECTED]


I've noticed that the AbstractFacesBean have a number of message methods (info,
error, warn, fatal) that take a UIComponent parameter, but they don't use it.

Class: org.apache.shale.view.AbstractFacesBean
Lines: 223-347

The current implementation is (for the info method):

    protected void info(UIComponent component, String summary) {

        getFacesContext().addMessage(null,
          new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null));

    }

and I'm assuming it should be something like:

    protected void info(UIComponent component, String summary) {
        FacesContext facesContext = getFacesContext();
        facesContext.addMessage(component.getClientId(facesContext),
          new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null));

    }

This pattern is the same for warn, error and fatal methods that take a
UIComponent parameter.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to