DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36794>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36794 ------- Additional Comments From [EMAIL PROTECTED] 2005-11-13 09:42 ------- Firstly, apologies for not commenting earlier... Wouldn't it be better if the Enhancer created was cached in the DynaClass? That way, rather than creating all these objects (i.e. Map of properties, InterfaceMaker, interface, Enhancer and BeanInterceptor) every time a new DynaActionForm is created they would just be done once and then the newInstance () method would just need to call the Enhancer.create() method. I also think this would be better as a separate class that could be plugged into any DynaClass. Why not just make BeanInterceptor a public class and add a factory method which creates the Enhancer - sinature something like: public Enhancer createEnhancer(DynaClass dynaClass, Class beanClass) I'm also wondering whether this feature should be "configurable" rather than the default behaviour. DynaActionForm users who are not interested in using this feature now have the additional overhead of this reflection and if anything in these changes breaks DynaActionForm that could affect alot of people. My gut feeling is that at this stage (with Ted planning to roll a 1.3 version) adding this kind of feature should be an optional extra and not the default for all DynaActionForm users. Also, the reflection code in BeanInterceptor to execute the DynaBean getter/setter methods seems unnecessary - one of the benefits of DynaBean is that they just have 6 get/set methods. Can't they just be called directly? Another thing I noticed - you're only creating methods for the simple get/set DynaBean methods when you create the InterfaceMaker - what about the indexed get/set methods as well (presumably theres no point doing the mapped get/set - since JSTL would have no knowledge of them anyway). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
