Christian Meder wrote:
On Thu, 2005-11-17 at 16:29 -0500, Laurie Harper wrote:
Christian Meder wrote:
On Thu, 2005-11-17 at 03:40 +0000, [EMAIL PROTECTED] wrote:
/**
+ * <p>The CGLIB <code>Enhancer</code> which we will use to dynamically
+ * add getters/setters if 'enhanced' is true in the form config.
+ */
+ protected transient Enhancer enhancer = null;
Shouldn't we mark enhancer private as getBeanEnhancer will always do the
right thing ?
protected seems to be the norm in Struts code for members of classes
likely to be subclassed. This is just consistent with other members in
the class.
Just after posting I saw that it's consistent with other members in the
class ;-)
But that still leaves the point that the re-introspection after
deserialization isn't properly encapsulated and bug-prone if you can
access the enhancer directly without the check. Consistently the same
issue for the other transient members like beanClass ;-)
That's true. The others obviously can't change without breaking backward
compatibility, though. I guess we could make this one field private to
shut that one door...
L.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
