On 12/3/05, Don Brown <[EMAIL PROTECTED]> wrote: > Since this is my first Struts release, I created a test build [1] for > the Struts Scripting 1.0.0 release that I'd like some feedback, por > favor, from the distribution gods (I'm looking at you Martin, Niall, and > Wendy) :) If no one sees anything horribly wrong, I'd like to roll the > release and start the quality vote tomorrow. > > Thanks for the help and patience, > > Don > > [1] http://people.apache.org/~mrdon/struts-scripting
I looked around, and didn't find anything horribly wrong. :) Here's my list: The .jar file is missing NOTICE.txt. (I can't find the message, but I think Phil on commons-dev mentioned that Maven should _automatically_ handle NOTICE.txt. It might be something added recently and not released yet, though. If not, a <resource> in project.xml should do it.) The NOTICE.txt in the top level of the .zip file mentions ANTLR, which I don't see anywhere in Scripting. (Though this seems to be the standard Struts NOTICE.txt, so maybe it needs to be there.) I had trouble with the example app until I changed unpackWARs to true. Granted, it's not too useful to run it from a packed WAR file because you can't edit the scripts, but... The Walking Tour in the example app says it's based on Struts 1.2.0 and has links to jakarta.apache.org. The registration page has 1.2.1-dev as the version number. Consider expanding the import statements in the .bsh files so I don't have to guess where the classes are coming from. :) The download link on the website (and included documentation) is to a SourceForge site. (?) HTH, -- Wendy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
