On 11/30/05, Martin Cooper <[EMAIL PROTECTED]> wrote: > > On 11/30/05, Laurie Harper <[EMAIL PROTECTED]> wrote: > > > > Wendy Smoak wrote: > > > On 11/30/05, Martin Cooper <[EMAIL PROTECTED]> wrote: > > > > > >> There was a thread somewhere recently (I'm afraid I don't recall > where) > > >> about going in the opposite direction, for a good reason that I don't > > >> recall. I'm hoping someone else here saw the same thing and has a > > better > > >> memory. ;-) IIRC, the solution was to make the log instance transient > > and > > >> access it through a getter. > > > > > > Possibly... > > > > > > http://www.nabble.com/-logging-Advice-on-static-instance-transient-Log-variables-t602568.html > > > Yep, that's the one. Wendy, you are now officially my memory. ;-)
How does she *do* that ... :-) Thanks for the link. If I understand the issue correctly, it would only > > be a problem is you had a logging implementation in the application > > classpath (WEB-INF/lib) but struts-action.jar in a shared classpath > > ($TOMCAT_HOME/common/lib or similar). > > > > If I recall correctly, putting Struts in a shared classpath like that is > > strongly discouraged and/or won't work anyway, so do we need to worry > > about this? > > > Actually, it's not just strongly discouraged - we officially claim to not > support such a scenario (or at least we used to). So you're right, we > shouldn't worry about it. Sorry for the false alarm. I was the author of that original warning that's still in the user guide: http://struts.apache.org/struts-action/userGuide/configuration.html#config_add This statement was originally written in the 1.0 days when servlet container class loaders were all over the map in their functionality, and it was very difficult to support a shared installation environment cleanly. But that was then and this is now ... I think it's probably reasonable to consider "install struts jars in a server's shared class loader" as a use case that we want to officially support, in all our framework projects. I'm gonna start fixing the Shale references to static Log instances (quite a few of them) and then run some experiments to see if there are still memory leaks. -- > Martin Cooper Craig
