Author: craigmcc
Date: Sun Jan 15 22:27:27 2006
New Revision: 369370
URL: http://svn.apache.org/viewcvs?rev=369370&view=rev
Log:
Clean up a bunch of PMD nags. The remaining ones about unused imports are
bogus, because PMD does not consider "[EMAIL PROTECTED] Foo}" in a Javadoc
comment to
be a legitimate reason to import class Foo.
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/application/AbstractRegExpFilter.java
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleApplicationFilter.java
struts/shale/trunk/core-library/src/java/org/apache/shale/remote/RemoteCommand.java
struts/shale/trunk/core-library/src/java/org/apache/shale/util/LoadBundle.java
struts/shale/trunk/core-library/src/java/org/apache/shale/validator/CommonsValidator.java
struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/CallbacksFactory.java
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/application/AbstractRegExpFilter.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/application/AbstractRegExpFilter.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/application/AbstractRegExpFilter.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/application/AbstractRegExpFilter.java
Sun Jan 15 22:27:27 2006
@@ -227,7 +227,7 @@
*/
protected void accept(ShaleWebContext context) throws Exception {
- ;
+ // No action required
}
@@ -325,7 +325,7 @@
try {
type = st.nextToken();
} catch (IOException e) {
- ; // Can not happen
+ // Can not happen
}
if (type == StreamTokenizer.TT_EOF) {
break;
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
Sun Jan 15 22:27:27 2006
@@ -289,7 +289,6 @@
* @param context The FacesContext for this request
*/
public void encodeBegin(FacesContext context) throws IOException {
- String id = getClientId(context);
ResponseWriter writer = context.getResponseWriter();
validators.clear();
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleApplicationFilter.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleApplicationFilter.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleApplicationFilter.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleApplicationFilter.java
Sun Jan 15 22:27:27 2006
@@ -386,24 +386,6 @@
/**
- * <p>Return the JSF <code>Lifecycle</code> instance for this
- * web application.</p>
- */
- private Lifecycle getLifecycle() {
-
- String lifecycleId =
- context.getInitParameter("javax.faces.LIFECYCLE_ID");
- if (lifecycleId == null) {
- lifecycleId = LifecycleFactory.DEFAULT_LIFECYCLE;
- }
- LifecycleFactory factory = (LifecycleFactory)
- FactoryFinder.getFactory(FactoryFinder.LIFECYCLE_FACTORY);
- return factory.getLifecycle(lifecycleId);
-
- }
-
-
- /**
* <p>Create and return the [EMAIL PROTECTED] ViewControllerMapper}
instance
* we will use for this application
*
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/remote/RemoteCommand.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/remote/RemoteCommand.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/remote/RemoteCommand.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/remote/RemoteCommand.java
Sun Jan 15 22:27:27 2006
@@ -300,7 +300,7 @@
try {
type = st.nextToken();
} catch (IOException e) {
- ; // Can not happen
+ // Can not happen
}
if (type == StreamTokenizer.TT_EOF) {
break;
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/util/LoadBundle.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/util/LoadBundle.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/util/LoadBundle.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/util/LoadBundle.java
Sun Jan 15 22:27:27 2006
@@ -229,7 +229,7 @@
int size = 0;
Enumeration keys = bundle.getKeys();
while (keys.hasMoreElements()) {
- Object key = keys.nextElement();
+ keys.nextElement();
size++;
}
return size;
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/validator/CommonsValidator.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/validator/CommonsValidator.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/validator/CommonsValidator.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/validator/CommonsValidator.java
Sun Jan 15 22:27:27 2006
@@ -534,6 +534,7 @@
try {
msg = bundle.getString(msgkey);
} catch (MissingResourceException ex) {
+ // Ignore this
}
}
if (msg == null) {
@@ -543,6 +544,7 @@
try {
msg = bundle.getString(msgkey);
} catch (MissingResourceException ex) {
+ // Ignore this
}
}
}
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/CallbacksFactory.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/CallbacksFactory.java?rev=369370&r1=369369&r2=369370&view=diff
==============================================================================
---
struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/CallbacksFactory.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/CallbacksFactory.java
Sun Jan 15 22:27:27 2006
@@ -62,7 +62,7 @@
try {
clazz =
cl.loadClass("org.apache.shale.tiger.view.faces.ViewControllerCallbacks2");
} catch (ClassNotFoundException e) {
- ;
+ // Deliberate fall through
}
if (clazz == null) {
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
