DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38613>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38613





------- Additional Comments From [EMAIL PROTECTED]  2006-02-12 06:15 -------
I like the idea of turning the multipart handling into a chain. However, I have
some concerns about the implementation. For example, I'm not thrilled about
ActionContextBase having to know about multipart handlers. I'm also concerned
about preserving the existing context when the request is wrapped; I'm afraid I
haven't had enough time to dig into the code yet to see it that all works
properly. Finally, this makes it so easy to customise multipart handling that
I'd much prefer to expose a cleaned up interface rather than the very clunky one
we've been living with since pre-1.0 days. On the plus side, this has the
potential to re-introduce the ability to disable multipart handling completely,
which is something we had in early Struts versions that got lost somewhere along
the way.

Really, multipart support should be moving to a filter now, rather than being so
intertwined with the request processing. I actually have the implementation for
this as part of FileUpload sitting on my disk, but I wasn't happy enough with it
to put it in FileUpload 1.1. Of course, Struts will still have to recognise the
wrapped request, with the file items in it, but it will certainly reduce the
amount of custom code in Struts.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to