DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38343>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38343 ------- Additional Comments From [EMAIL PROTECTED] 2006-03-08 02:18 ------- Thanks for submitting this Paul. I have added this to the current trunk and 1.2.x branch: http://svn.apache.org/viewcvs?rev=384090&view=rev http://svn.apache.org/viewcvs?rev=384092&view=rev ...with a few changes: 1) Renamed ParameterListActionDispatcher to EventActionDispatcher. 2) Fixed a few checkstyle issues and modified some javadocs. 3) It was throwing a NullPointerException if a parameter was not specified - changed it log and throw a servlet exception in the getParameter() method. 4) If a method can't be identified (and no default was specified), it showed the parameter value in the exception's error message (default ActionDispatcher behaviour) which reveals "obfuscated" method names. I added a check in getMethodName() which throws an exception which doesn't reveal the parameter value. 5) I removed the "impliedSingleDefault" feature, since if people want MappingDispatchAction behaviour they can simply use either the MappingDispatchAction or ActionDispatcher implementations - or simply specify a "default" value in the parameter. This (slighty) simplifies things which is better IMO. 6) I also added a DispatchAction flavour (called EventDispatchAction) - so people can choose what style they prefer (DispatchAction or ActionDispatcher style) 7) I also added tests/examples to the struts-examples webapp: http://svn.apache.org/viewcvs?rev=384091&view=rev http://svn.apache.org/viewcvs?rev=384093&view=rev In order to accomodate the new EventDispatchAction, I did a small bit of refactoring in DispatchAction. This allows the two "event" flavours (EventDispatchAction and EventActionDispatcher) to be almost identical. http://svn.apache.org/viewcvs?rev=384088&view=rev http://svn.apache.org/viewcvs?rev=384089&view=rev I hope this is all acceptable, apologies in advance if the changes upset you. If theres anything you really don't like we can discuss and (maybe) modify. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
