On 3/9/06, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > OK, looks like MultipartBoundaryInputStreamTest isn't being run and I > can't > find any evidence of it ever having been run - even in Struts 1.1 when > that > test was added. The class its testing (MultipartBoundaryInputStream) has > been deprecated in favour of Commons Fileupload (and removed in Struts 1.3 > ). > Sorry don't know the history behind it - one thing is that it seems > incorrect for cactus to be trying to run that test - looks like a normal > JUnit test case to me (and I can't even work out how cactus is kicked off > by > maven anyway).
Wow, that's ancient history. ;-) It's part of the original multipart handler that never really worked very well, and was broken enough that I gave up on trying to fix all the bugs and wrote the one that sits on top of Commons FileUpload instead. I don't remember for sure - it's been too long - but I suspect the tests never worked properly, since the implementation didn't either. It sounds like this test isn't being run when using Ant, but is with Maven. If it's causing problems for Maven users (and the build otherwise works), I think we should probably just zap the test class. Nobody should be using the old multipart handler anyway, so there's no point in testing it. -- Martin Cooper Niall > > ----- Original Message ----- > From: "Henri Yandell" <[EMAIL PROTECTED]> > Sent: Friday, March 10, 2006 1:10 AM > > > When I run the Cactus tests through Maven against Tomcat 4.1.31, I get > three failed tests in the MultipartBoundaryInputStreamTest. I'm on the > 1.2.X branch. > > I presume that people mostly do it with Ant, so will dig into getting > that setup, but thought I'd report the problem. > > Hen > > Errors follow: > > [cactus] FAILED > [cactus] Actual bytes don't match the desired bytes > [cactus] junit.framework.AssertionFailedError: Actual bytes don't > match the desired bytes > [cactus] at > org.apache.struts.upload.MultipartBoundaryInputStreamTest.assertEquals > (Multi > partBoundaryInputStreamTest.java:661) > [cactus] at > org.apache.struts.upload.MultipartBoundaryInputStreamTest.testProblemFile2 > (M > ultipartBoundaryInputStreamTest.java:528) > [cactus] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > [cactus] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java > :39 > ) > [cactus] at > sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl > .java:25) > [cactus] > [cactus] Testcase: testProblemFile2Testcase: testProblemFile3 took > 0.007 > sec > [cactus] FAILED > [cactus] Actual bytes don't match the desired bytes > [cactus] junit.framework.AssertionFailedError: Actual bytes don't > match the desired bytes > [cactus] at > org.apache.struts.upload.MultipartBoundaryInputStreamTest.assertEquals > (Multi > partBoundaryInputStreamTest.java:661) > [cactus] at > org.apache.struts.upload.MultipartBoundaryInputStreamTest.testProblemFile3 > (M > ultipartBoundaryInputStreamTest.java:591) > [cactus] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > [cactus] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java > :39 > ) > [cactus] at > sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl > .java:25) > [cactus] > [cactus] Testcase: testProblemFile3Testcase: testMaxLengthExceeded > took 0.005 sec > [cactus] FAILED > [cactus] null > [cactus] junit.framework.AssertionFailedError > [cactus] at > > org.apache.struts.upload.MultipartBoundaryInputStreamTest.testMaxLengthExcee > ded(MultipartBoundaryInputStreamTest.java:650) > [cactus] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > [cactus] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java > :39 > ) > [cactus] at > sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl > .java:25) > [cactus] > [cactus] Testcase: testMaxLengthExceeded > [cactus] [ERROR] TEST > org.apache.struts.upload.MultipartBoundaryInputStreamTest FAILED > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
