As you can imagine, I found this problem because I went to validate and ISBN and couldn't find the right FieldChecks name :)
Please open up a JIRA ticket. I haven't signed up for JIRA yet. Paul --- Niall Pemberton <[EMAIL PROTECTED]> wrote: > Its not just the case of adding an entry to the validator-rules.xml - > FieldChecks would also need a new ISBN validation method. > > As to the reason it hasn't been added to Struts - the first thing is > that the ISBN validator has only been available since Validator 1.2.0 > and that was only released in Nov 2005. More importantly though I > guess no-one has had the need to use it - thats true for me and I > didn't actually notice it wasn't in there. AFAIK theres no reason not > to add it. > > If anyone does add it in to struts then besides adding a new > FieldChecks method and updating the validator-rules.xml it would also > be good to update the validator user guide (with a note indicating > theres no Javascript version) and adding an ISBN example to the > "types" page in the struts-examples webapp (as well as having an > example it means we have something that can be tested). > > Do you want to add a JIRA ticket for this Paul - if not I will. > > Niall > > On 5/21/06, Paul Benedict <[EMAIL PROTECTED]> wrote: > > I don't know the rule either, but I think it is odd leaving > > it out. All the new locale validators have an entry, but this one > > does not. I'd say this was forgotten, unless there was a technical > > reason to leave it out. Niall? -- Paul > > > > --- Martin Cooper <[EMAIL PROTECTED]> wrote: > > > > > On 5/19/06, Paul Benedict <[EMAIL PROTECTED]> wrote: > > > > > > > > I noticed there is no ISBN validator defined in > > > > validator-rules.xml for Struts 1.3. It is missing. > > > > Is this a bug? > > > > > > > > > I don't think so. The ISBNValidator class is part of Commons Validator, so > > > it's still available to those who wish to use it. But then again, I'm not > > > totally sure what the rule is - if there is one - for when we create an > > > entry in the Struts file versus leaving it up to the user, so I could be > > > wrong. ;-) > > > > > > -- > > > Martin Cooper > > > > > > > > > -- Paul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
