Yes, as to Action1, the vast majority of the style errors are a fair
cop and reflect things we shouldn't be doing.
Of course, as far as Action 1 is concerned, it's a fair question of
whether the checkstyle report adds any value. No one appears
interested in fixing the errors, and so there are still so many errors
that new ones go unnoticed.
I notice that as to Action2, the check style plugin is commented out.
I tried enabling it on my working copy, but then it wouldn't build.
: reference not found: ConversionErrorInterceptor
C:/projects/Apache/struts-current/action2/core/src/main/java/org/apache/struts/action2/dispatcher/VelocityResult.java:80:
warning - Tag @link: reference not found: JspFactory
at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeReport(Abs
tractJavadocMojo.java:845)
at org.apache.maven.plugin.javadoc.JavadocReport.generate(JavadocReport.
java:104)
at org.apache.maven.plugins.site.SiteMojo.generateReportsPages(SiteMojo.
java:802)
at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:301)
... 18 more
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28 seconds
[INFO] Finished at: Sun Jun 11 20:58:44 EDT 2006
[INFO] Final Memory: 20M/35M
[INFO] ------------------------------------------------------------------------
Do we know what is the problem with running checkstyle with Action2?
-Ted.
On 6/11/06, Martin Cooper <[EMAIL PROTECTED]> wrote:
You can blame whoever wrote the code. ;-) The Checkstyle rules for Struts
have been in place for _years_, and it's been trivial to run a Checkstyle
report for almost as long - even before we had 'ant release'. The original
rules were based on the Sun / Craig coding conventions, so you shouldn't
have a problem with them the way they are now. ;-) I am not in favour of
changing them to reflect the mess the code base has got into. That's like
changing the law just because people keep breaking it.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
