Yeah, I did have to put the filters back to their original state. I found the _dispatcher and dispatcher variables really confusing and I'm not sure I understand the original usecase why the cleanup filter needs to have a dispatcher instance at all. Could you go into detail why the cleanup filter needs to initialize the dispatcher?

Don

tm jee wrote:
Hi guys, There might be a fix releated to this (https://issues.apache.org/struts/browse/WW-1489) that seems to be broken. WW-1489 abstracted the common logic from both DispatcherFilter and ActionContextCleanUp to an Abstract filter. With the latest commit, FilterDispatcher is put back to its old state (plus the new DI code) and AbstractFilter was deleted.
I guess its ok to revert back to the old state but ActionContextCleanUp is not 
reverted totally to its old state, such that it doesn't initialize Dispatcher 
etc. The consequence i guess would be that sitemesh will not have access to 
struts2 value stack etc. Is this the itended behaviour or am i missing 
something?

Tia

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to