Don't worry about the remote Div and the submit tag, I will check them out and fix them. About the broken links, are they in the pages that I changed? I'm not sure which ones you are talking about. I have to update the javadoc comments also.
musachy On 11/13/06, Rainer Hermanns <[EMAIL PROTECTED]> wrote:
Musachy, others, I applied all of your patches and fixed some minor things I found myself. However, there seems to be still a problem with the remotediv and remoteform samples in showcase. It seems to me, that the initial and refresh loading is not working as expected. I am not yet sure where to look for the error exactly, still hunting for it... If you got an idea or this is still an open issue, please let me know :) Another problem seems to appear with the changed submit tag logic. IIRC you removed the action attribute and replaced it with an href attribute. But the reworked href attribute does not take care of the action:actionName notation. Another issue is open with the showcase samples. A lot of pages are not working or linked files are missing. Also, the navigation within showcase seems to be broken. Tomorrow, after daytime work, I'll try to tackle most of these issues. later, Rainer > Let me know if you find any problem, I don't have much to do this weekend > :) > > musachy > > Rainer Hermanns wrote: >> Musachy send me the required files via email. >> >> I am currently in progress of incorporating the patches into the locally >> updated repo. I'll work further on these over the weekend, so that dojo >> 0.4 with (hopefully) working ajax tags should be in place until monday. >> >> regards, >> Rainer >> >> >>> Does this list accept attachments? It got rejected as spam :) >>> >>> Rainer Hermanns wrote: >>> >>>> No idea, just zip together the newly created dir and I'll add the >>>> files >>>> individually :) >>>> >>>> tia, >>>> Rainer >>>> >>>> >>>> >>>>> You are right, the patch doesn't include the new files inside the >>>>> added >>>>> folder, I can't figure out how to make svn create a patch with the >>>>> added >>>>> folder, it keeps complaining: >>>>> >>>>> "Files inside the added folder won't be included ...." >>>>> >>>>> Am I doing something wrong or this is a svn/patch limitation? >>>>> >>>>> musachy >>>>> >>>>> Rainer Hermanns wrote: >>>>> >>>>> >>>>>> Ah, okay... So it looks like the complete folder with all moved >>>>>> widget >>>>>> files >>>>>> is missing. The patch does not create the folder, nor does it create >>>>>> the >>>>>> "new/moved" template files. >>>>>> >>>>>> thanks for your help, >>>>>> Rainer >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> I will take a look tomorrow (not on my box right now), but I do >>>>>>> remember >>>>>>> that I changed the widgets to struts.widget from struts.widgets, >>>>>>> for >>>>>>> 2 >>>>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway) >>>>>>> and >>>>>>> 2. >>>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget" >>>>>>> which >>>>>>> requires less configuration. I will let you know tomorrow. >>>>>>> >>>>>>> thanks >>>>>>> >>>>>>> musachy >>>>>>> >>>>>>> On 11/5/06, Rainer Hermanns <[EMAIL PROTECTED]> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Musachy, >>>>>>>> >>>>>>>> after applying your patch, all custom widget files do no longer >>>>>>>> have >>>>>>>> content. >>>>>>>> Is it correct, that all files under core/src/main/resources/org/ >>>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed? >>>>>>>> >>>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/ >>>>>>>> dojoRequire.js should be changed like this (remove all lines with >>>>>>>> '-' >>>>>>>> ): >>>>>>>> >>>>>>>> dojo.require("dojo.io.BrowserIO"); >>>>>>>> dojo.require("dojo.event.topic"); >>>>>>>> >>>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts'); >>>>>>>> dojo.require('dojo.widget.*'); >>>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget'); >>>>>>>> >>>>>>>> - dojo.require("struts.widget.Bind"); >>>>>>>> - dojo.require("struts.widget.BindDiv"); >>>>>>>> - dojo.require("struts.widget.BindAnchor"); >>>>>>>> dojo.require("dojo.widget.Editor"); >>>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the >>>>>>>> Venkman >>>>>>>> debugger to work with the includes >>>>>>>> >>>>>>>> It looks to me, that either the patch is not complete, or that I >>>>>>>> am >>>>>>>> missing the part replacing the above widget requirements. >>>>>>>> >>>>>>>> Could you please have a look at this? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Rainer >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>>>>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> -- >>>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>>> >>>>> >>>>> >>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>> >>>> >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- "Hey you! Would you help me to carry the stone?" Pink Floyd