Don,

I agree. As my m2 skills could be titled basic at most, would you (or someone 
else more experienced than me) mind taking the task of creating plugin for the 
annotation stuff? I'll continue converting component sources to use annotarions 
then.

Regards,
Rene

> I think we should follow the general rule, "If in
> doubt, leave it out".  
> We can always add it back in if we discover a need
> sometime in the 
> future, but if it is now, we'll have to keep it in
> for all future 
> versions.  I want to keep core as simple as possible,
> to encourage both 
> new Struts 2 committers and users.
> 
> Don
> 
> Rene Gielen wrote:
> > Don,
> >
> > good point! This would be much cleaner, yes. Btw, I
> must admit I still 
> > have to learn about the new possibilities of the
> modularized build 
> > system :)
> >
> > The question is if we want to push out the whole
> stuff under 
> > oas2.annotations or just the apt subpackage, which
> is clearly used 
> > only during compile time.
> >
> > Although I cannot see a proper usecase for runtime
> processing of the 
> > said annotations right now, I feel like annotation
> classes itself 
> > belong to core or at least to the runtime
> accessible stuff as they 
> > provide, well, meta information on it, which can
> optionally be 
> > processed during compile time or runtime...
> >
> > Regards,
> > Rene
> >
> > Don Brown schrieb:
> >> Rene, is there any reason this code should go into
> Struts 2 core?
> >> Does it need to referenced at runtime?  I thought
> you were using these
> >> annotations at compile time, which AFAIK, means
> they won't be included
> >> in the compiled code, so there would be no reason
> to include the
> >> annotation code in the jar.
> >>
> >> I think this should be pushed out to a new Maven 2
> plugin, perhaps
> >> under /struts/maven instead of Struts 2.
> >>
> >> Don
> >>
> >> On 11/21/06, Rene Gielen
> <[EMAIL PROTECTED]> wrote:
> >>> I committed Musachy's patch with some
> modifications, so that the 
> >>> annotations are in place as well as the apt
> generation code, so we 
> >>> all can give it a review. Maybe we will have to
> do some more 
> >>> changes, but it looks quite straight forward in
> the first place.
> >>>
> >>> Converting doc-tags to annotations is supposed to
> be a dirty job, 
> >>> I've done some tests and will continue tomorrow.
> May the regexes be 
> >>> with us ... :)
> >>>
> >>> Nonetheless, we still can work "on both ends",
> giving both the apt 
> >>> and xd2 a try while having common meta
> information convention. I was 
> >>> not able to look into Konstantins patch yet, but
> I will do ASAP 
> >>> after doing the conversion stuff.
> >>>
> >>> Regards,
> >>> Rene
> >>>
> >>> > I have everything working fine, but I'm waiting
> to
> >>> > get home and retest
> >>> > it on linux before submitting.
> >>> >
> >>> > musachy
> >>> >
> >>> > Ted Husted wrote:
> >>> > > Likewise. Either will be fine with me. From
> the
> >>> > other thread, I think
> >>> > > Rene was going to look at apt again later
> today.
> >>> > >
> >>> > > -Ted.
> >>> > >
> >>> > > On 11/20/06, Don Brown <[EMAIL PROTECTED]>
> wrote:
> >>> > >> I believe whoever is planning on doing the
> actual
> >>> > commit decides..... I
> >>> > >> call "not it!" :)
> >>> > >>
> >>> > >> Don
> >>> > >>
> >>> > >> James Mitchell wrote:
> >>> > >>
> >>> > >> > I was under the impression that we were
> going to
> >>> > use apt.
> >>> > >> >
> >>> > >> > --
> >>> > >> > James Mitchell
> >>> > >> > 678.910.8017
> >>> > >
> >>> > >> >
> >>> > >> > On Nov 19, 2006, at 6:33 PM, Musachy
> Barroso
> >>> > wrote:
> >>> > >> >
> >>> > >> >> Are we finally going to stick to xdoclet
> or use
> >>> > annotations?  I  have
> >>> > >> >> the
> >>> > >> >> maven-apt plugin  almost ready(from
> tobago
> >>> > project + some fixes)
> >>> > >> >> with the
> >>> > >> >> apt stuff, but I don't want to spend more
> time
> >>> > on it if we are not
> >>> > >> >> going to
> >>> > >> >> use it.
> >>> > >> >>
> >>> > >> >> regards
> >>> > >> >> musachy
> >>> > >> >>
> >>> > >> >> On 11/18/06, Konstantin Priblouda
> >>> > <[EMAIL PROTECTED]> wrote:
> >>> > >> >>
> >>> > >> >>>
> >>> > >> >>> HI all,
> >>> > >> >>>
> >>> > >> >>> I just created an issue containing patch
> to
> >>> > pom.xml
> >>> > >> >>> to enable tld-generation by xdoclet-2
> >>> > >> >>> ( WW-1512 )
> >>> > >> >>>
> >>> > >> >>> feel free to ask questions.
> >>> > >> >>>
> >>> > >> >>> regards,
> >>> > >> >>>
> >>> > >> >>> ----[ Konstantin Pribluda
> >>> > http://www.pribluda.de ]----------------
> >>> > >> >>> Still using XDoclet 1.x?  XDoclet 2 is
> >>> > released and of production
> >>> > >> >>> quality.
> >>> > >> >>> check it out:
> http://xdoclet.codehaus.org
> >>> > >> >>>
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=50761&messageID=102998#102998


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to