I have attached a patch and a gif file to WW-1554. Because the patch to
WW-1555 has not been applied, there might be some small conflicts on
struts-tld.xml. If you guys find anything still missing (hope not :) ),
let me know.
regards
musachy
Don Brown wrote:
Musachy Barroso wrote:
That said, could you go through your tag changes and ensure that we
have kept all tags and attributes as they were, and explicitly list
those that you really feel we should remove/change. The original
WebWork 2.2 tags may have not been the best named, most consistent,
or fully featured, but we need to make the best possible effort to
keep within those lines.
I will, it is mostly about names, we have more functionality than
before, not less. Could we consider changing
preInvokeJS ->beforeLoading
onLoadJS ->afterLoading
If we did, we'd have to keep the old attributes and mark them as
deprecated. Any objections?
at least?
musachy
//annoying patch coming your way :)
Patches are never annoying :)
Don
Struts 2.0 is advertised as a smooth, painless upgrade for WebWork
2.2 applications, and to make that happen, we need to be very, very
careful.
Don
Musachy Barroso wrote:
Good that you mentioned 'cause I hadn't seen it. First thing,
"notifyTopics" ,my bad, I forgot to fix it, easy to fix. The
attributes that are a little bit problematic cause they were not
consistent between the different tags are:
preInvokeJS (in anchor, not in div), shouldn't this one be
"beforeLoading"?
afterLoading (in anchor and div, not in submit)
onLoadJS (only on submit), same as "afterLoading" but with a
different name.
notifyTopics (only on anchor)
listenTopics (div and submit)
being new here, I tried to make them consistent and I ended up
messing the backward compatibility because of the attribute names.
Functionality-wise I think pretty much all is there.
musachy
Martin Cooper wrote:
Oops! Forgot [1]: https://issues.apache.org/struts/browse/WW-1554
On 12/9/06, Martin Cooper <[EMAIL PROTECTED]> wrote:
As Don has noted [1], there are some tag attributes (e.g.
notifyTopics)
that have disappeared recently. It seems that, included in the
patch to
upgrade Dojo to version 0.4, there were other changes that have
caused
incompatibility with earlier versions. I don't claim to be an
expert on the
tags, by any stretch of the imagination, but I can't see any
reason for
changing the attributes here, and hence the public API,
especially as part
of a Dojo dependency upgrade.
Can someone help me understand why attribute compatibility needed
to be
broken as part of the Dojo upgrade?
--
Martin Cooper
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
