Horray, we have a Green build for trunk. I neatly sidestepped the annotations issue and deployed the 1.0.2-SNAPSHOT, then fixed the tests for the blank webapp. The problem is when we fixed the inconsistent naming of result types, we removed the deprecated ones. Shouldn't we leave them in for at least another release, or worst case, figure out how to throw better errors when used?
Don On 3/12/07, James Mitchell <[EMAIL PROTECTED]> wrote:
Based on this log... http://opensource.bamboo.atlassian.com/build/viewBuildLog.action? buildKey=STRUTS-MAIN&buildNumber=216 s2/core requires struts-annotations-1.0-SNAPSHOT, which is on the maven repo, but plugins/dojo requires 1.0.2 snapshot. Unless someone pushes the 1.0.2 snapshot to the snapshot repo, you (who ever that is) can add the 'struts-annotations' profile to the build. Or, move plugins/dojo to 1.0-SNAPSHOT, which I just tried locally and it works fine. (based on the above link) ...java/tools/maven2/bin/mvn -Pplugins,apps clean install ^---- right here I'd fix it but I'm not sure which route to take. -- James Mitchell The Ruby Roundup http://www.rubyroundup.com/ On Mar 12, 2007, at 10:21 PM, Ted Husted wrote: > The head has a dependency on the Struts Annotation snapshot, but > Bamboo doesn't know how to build that. > > -T. > > On 3/12/07, Don Brown < [EMAIL PROTECTED]> wrote: >> Bamboo is back up, but it seems recent commits have resulted in a >> failed >> build for trunk. Interestingly, 2.0.x is green. Ted, any chance >> one of >> your recent commits could be breaking those three tests? >> >> http://opensource.bamboo.atlassian.com/browse/STRUTS >> >> Don >> >> On 3/11/07, Ted Husted <[EMAIL PROTECTED]> wrote: >> > >> > Thanks, Don. It's good to be back on track again. >> > >> > I'd also suggest that if the build or tests is broken when you >> want to >> > commit something, and you don't see how to fix it, go ahead and >> roll >> > back the last commit, so that it does build, and then commit >> your own >> > changes. Otherwise, we end up with "broken window" syndrome. >> > >> > -Ted. >> > >> > On 3/11/07, Don Brown <[EMAIL PROTECTED]> wrote: >> > > Please, please, please eveyone, if you happen to break the >> build, fix it >> > > ASAP. It brings down the quality of the project and is rather >> > embarrassing. >> > > >> > > Thanks, >> > > >> > > Don >> > > >> > > On 3/11/07, Ted Husted <[EMAIL PROTECTED]> wrote: >> > > > >> > > > I may have broken some of them this morning by removing >> > > > struts.properties from the apps. I'm looking now. >> > > > >> > > > -Ted. >> > > > >> > > > On 3/11/07, Don Brown < [EMAIL PROTECTED]> wrote: >> > > > > This has gone on long enough - there will be no more >> commits until >> > the >> > > > build >> > > > > has been fixed. Currently, I'm seeing compilation >> problems in the >> > tiles >> > > > > plugin and 22 tests broken due to the consistent naming >> > commit. Until >> > > > the >> > > > > build has been fixed and all tests pass, only commits that >> address >> > these >> > > > > issues should go through. >> > > > > >> > > > > When the build is broken, it makes it harder to protect >> against >> > > > regression >> > > > > bugs and just plain looks bad. Right now, it seems we >> only have >> > Bamboo >> > > > > building trunk, so I'll add a plan for our 2.0.x branch. >> I'm happy >> > that >> > > > we >> > > > > seem to be moving forward with improvements and features, >> but it is >> > > > > important we maintain code quality. >> > > > > >> > > > > Don >> > >> > >> --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [EMAIL PROTECTED] >> > For additional commands, e-mail: [EMAIL PROTECTED] >> > >> > >> > > > -- > HTH, Ted < http://www.husted.com/ted/blog/> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
