It probably is inconsistent now. At one point, I'm pretty sure the code was consistent in using a 'this.' prefix only when necessary (e.g. in setters, like "this.foo = foo"), but that's probably no longer true. Oh well.
-- Martin Cooper On 6/28/07, Paul Benedict <[EMAIL PROTECTED]> wrote:
Yes, it is debatable. As I look through the Struts source code, I see this principle applied inconsistently. Sometimes qualified; others not. Otherwise, not a big deal. I could have not done it :-) On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote: > > The "best" part is debatable - it's certainly not one that I favour. ;-) > IMHO, it's redundant and clutters the code. > > -- > Martin Cooper > > > On 6/28/07, Paul Benedict <[EMAIL PROTECTED]> wrote: > > > > That's not why I added it. I added it out of best practice. > > > > On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote: > > > > > > On 6/26/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > > > > > Author: pbenedict > > > > Date: Tue Jun 26 23:05:09 2007 > > > > New Revision: 551067 > > > > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=551067 > > > > Log: > > > > STR-1175: Add instance qualification > > > > > > > > > Why? There doesn't appear to be any local variable for this one to be > > > confused with. > > > > > > > > >
