-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Don,

Don Brown wrote:
> Ah, that does look a lot better.  I still wish velocity supported 
> named parameters, but this is better than nothing.

Yeah, I pitched named parameters to the Velocity folks and they
generally balked because Velocity is simply not tag-based. It makes
sense, honestly.

> Could you file a ticket for this improvement please, and if you have
> time to write a patch, it would certainly be appreciated :)

I can certainly get started, but I'll need a lot of help. Basically,
every macro or directive (the Velocity implementation of a "tag") needs
to be re-written to accept a Map parameter.

Once I get into the code, I may find that I can simply add this
capability to the existing code, rather than duplicating it (which, of
course, would be ideal). I just need to check to make sure that no
current tags accept a Map as a single parameter /and/ get an agreement
from the S2 folks that they won't try to create a new tag that accepts a
Map as a single parameter, but doesn't do what my suggested changes do.

JIRA issue: https://issues.apache.org/struts/browse/WW-2807

- -chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjSVZQACgkQ9CaO5/Lv0PAv0wCfZ3S9EGVZQHsenjeuke0z6alc
euAAn2xVndQgcgini2sCB/mjo1Wjk6A6
=DIzi
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to