Woot! Very nice work on pusing this through Musachy!! I didn't even realize it happened. I rebuilt my Mac and went to the sandbox to rebuild convention and poof it was gone. I was very excited.
Musachy Barroso wrote: > > done > > On Tue, Dec 16, 2008 at 2:49 PM, Rainer Hermanns <herma...@aixcept.de> > wrote: >> +1 >> thanks a lot for taking care :) >> >> cheers, >> Rainer >>> The Multiple Unknown Handlers patch was merged into xwork and struts >>> trunks. Now we can move convention plugin out of the sanbox. Last call >>> for objections :) (2.1 build coming soon) >>> >>> musachy >>> >>> On Wed, Nov 26, 2008 at 5:06 PM, Musachy Barroso <musa...@gmail.com> >>> wrote: >>>> I updated the patch to use a 2.1 dtd, instead of 2.0, and removed the >>>> annoying empty lines from the diff. Crucible seems to have a bug, and >>>> even >>>> when I uncheck files from the "Patch" section, it keeps them in the >>>> review >>>> (take note Don :) ) >>>> >>>> http://fisheye6.atlassian.com/cru/DEMO-21 >>>> >>>> musachy >>>> >>>> On Sat, Nov 15, 2008 at 2:42 PM, <musa...@gmail.com> wrote: >>>>> >>>>> On our super long convention thread, we got to the agreement that in >>>>> order >>>>> to move convention out of the sandbox, there should be a way to run >>>>> both >>>>> plugins side by side, so backward compatibility could be possible. The >>>>> remaining issue to make that happen was to implement "multiple unknown >>>>> handler", for which I uploaded a new patch here (against trunk): >>>>> >>>>> http://jira.opensymphony.com/browse/XW-640 >>>>> (http://fisheye6.atlassian.com/cru/DEMO-19) >>>>> >>>>> that creates an extension point for unknown handlers manager, instead >>>>> of >>>>> some ugly static classes I wrote before. We also agreed to include >>>>> convention after 2.1 was released, but based on how long releases >>>>> take(hoping to change that soon), I propose that we move convention >>>>> out >>>>> of >>>>> trunk for the next 2.1 release so it will be available when 2.1 goes >>>>> GA, and >>>>> not 1 or 2 years after that. >>>>> >>>>> @Rainer, @Rene: could you guys take a look at the new patch? That >>>>> thing >>>>> was a pain to merge being so old, the new one should merge fine. >>>>> >>>>> regards >>>>> musachy >>>> >>>> >>>> -- >>>> "Hey you! Would you help me to carry the stone?" Pink Floyd >>>> >>> >>> >>> >>> -- >>> "Hey you! Would you help me to carry the stone?" Pink Floyd >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>> For additional commands, e-mail: dev-h...@struts.apache.org >>> >>> >> >> >> -- >> Rainer Hermanns >> aixcept >> Willibrordstraße 82 >> 52134 Herzogenrath - Germany >> w: http://aixcept.de/ >> t: +49 - 2406 - 979 22 11 >> f: +49 - 2406 - 979 22 13 >> m: +49 - 170 - 343 29 12 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >> For additional commands, e-mail: dev-h...@struts.apache.org >> >> > > > > -- > "Hey you! Would you help me to carry the stone?" Pink Floyd > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > > > -- View this message in context: http://www.nabble.com/Convention-plugin-recap---proposal-tp20518854p21130612.html Sent from the Struts - Dev mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
