I say call 2.1.3 a bust and move onto making 2.1.4 GA. I had to do 3
point releases from 1.3.5 to 1.3.8 to go GA. :-) Getting new features
to work right universally is a tough job.
Paul
On Sat, Dec 27, 2008 at 11:04 AM, Musachy Barroso <musa...@gmail.com> wrote:
> You are not using the new filters, so I guess something is went wrong
> in that refactoring. I will see if I cand find the problem, but the
> release cannot go out like this.
>
> musachy
>
> On Sat, Dec 27, 2008 at 11:12 AM, Al Sutton <a...@funkyandroid.com> wrote:
>> I'm sorry I didn't try the trunk sooner (too busy coding the site :().
>>
>> The filters are;
>>
>> <filter>
>> <filter-name>struts-cleanup</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
>> </filter>
>> <filter>
>> <filter-name>sitemesh</filter-name>
>>
>> <filter-class>com.opensymphony.module.sitemesh.filter.PageFilter</filter-class>
>> </filter>
>> <filter>
>> <filter-name>struts</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
>> <init-param>
>> <param-name>actionPackages</param-name>
>> <param-value>com.andappstore.actions</param-value>
>> </init-param>
>> </filter>
>> <filter-mapping>
>> <filter-name>struts-cleanup</filter-name>
>> <url-pattern>/*</url-pattern>
>> </filter-mapping>
>> <filter-mapping>
>> <filter-name>sitemesh</filter-name>
>> <url-pattern>/*</url-pattern>
>> </filter-mapping>
>> <filter-mapping>
>> <filter-name>struts</filter-name>
>> <url-pattern>/*</url-pattern>
>> </filter-mapping>
>> The sitemesh.xml is;
>>
>> <sitemesh>
>> <property name="decorators-file" value="/WEB-INF/decorators.xml" />
>> <excludes file="${decorators-file}" />
>>
>> <page-parsers>
>> <parser content-type="text/html"
>> class="com.opensymphony.module.sitemesh.parser.HTMLPageParser" />
>> <parser content-type="text/html;charset=ISO-8859-1"
>> class="com.opensymphony.module.sitemesh.parser.HTMLPageParser" />
>> </page-parsers>
>>
>> <decorator-mappers>
>> <mapper
>> class="com.opensymphony.module.sitemesh.mapper.AgentDecoratorMapper">
>> <param name="match.Android" value="android" />
>> </mapper>
>> <mapper
>> class="com.opensymphony.module.sitemesh.mapper.ConfigDecoratorMapper">
>> <param name="config" value="${decorators-file}" />
>> </mapper> </decorator-mappers>
>> </sitemesh>
>>
>> and the decorators.xml file is;
>>
>> <decorators defaultdir="/WEB-INF/decorators">
>> <excludes>
>> <pattern>/updates/*</pattern>
>> </excludes>
>> <decorator name="default" page="default.jsp">
>> <pattern>/*</pattern>
>> </decorator>
>> </decorators>
>>
>>
>>
>>
>>
>> Musachy Barroso wrote:
>>>
>>> this one looks bad, how do you have your filters configured? I think
>>> we saw this before and had been fixed.
>>>
>>> musachy
>>>
>>> On Sat, Dec 27, 2008 at 4:50 AM, Al Sutton <a...@funkyandroid.com> wrote:
>>>
>>>>
>>>> Next problem; I'm seeing an exception being thrown in Freemarker which I
>>>> believe is a knock on effect from the sitemesh plugin.
>>>>
>>>> When I set a breakpoint in FreemarkerTemplateEngine.renderTemplate there
>>>> are
>>>> several passes through where the servletcontext, request, and response
>>>> objects are pulled from the stack in the TemplateRenderingContext, but
>>>> then
>>>> nulls start to be returned and hence the NPE is thrown.
>>>>
>>>> I beleive this is when parsing a decorator containing S2 tags is included
>>>> because the output page contains the main data, the HTML components from
>>>> the
>>>> template, and then stops at the first S2 tag :( .
>>>>
>>>> Al.
>>>>
>>>> java.lang.NullPointerException
>>>> at
>>>>
>>>> org.apache.struts2.views.freemarker.FreemarkerManager.getConfiguration(FreemarkerManager.java:159)
>>>> at
>>>>
>>>> org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:89)
>>>> at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:559)
>>>> at org.apache.struts2.components.UIBean.end(UIBean.java:513)
>>>> at
>>>>
>>>> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:42)
>>>> at
>>>>
>>>> org.apache.jsp.WEB_002dINF.decorators.default_jsp._jspx_meth_s_005fhidden_005f0(default_jsp.java:668)
>>>> at
>>>>
>>>> org.apache.jsp.WEB_002dINF.decorators.default_jsp._jspService(default_jsp.java:162)
>>>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>>>> at
>>>>
>>>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
>>>> at
>>>> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
>>>> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:630)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:535)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:472)
>>>> at
>>>>
>>>> com.opensymphony.module.sitemesh.filter.PageFilter.writeDecorator(PageFilter.java:173)
>>>> at
>>>>
>>>> com.opensymphony.module.sitemesh.filter.PageFilter.applyDecorator(PageFilter.java:158)
>>>> at
>>>>
>>>> com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:62)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>>>> at
>>>>
>>>> org.apache.struts2.dispatcher.ActionContextCleanUp.doFilter(ActionContextCleanUp.java:102)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>>>> at
>>>>
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>>>> at
>>>>
>>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>>>> at
>>>>
>>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>>>> at
>>>>
>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
>>>> at
>>>>
>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>>>> at
>>>>
>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>>>> at
>>>>
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
>>>> at
>>>>
>>>> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
>>>> at
>>>>
>>>> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
>>>> at
>>>> org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
>>>> at java.lang.Thread.run(Unknown Source)
>>>>
>>>> --
>>>> ======
>>>> Funky Android Limited is registered in England & Wales with the company
>>>> number 6741909. The registered head office is Kemp House, 152-160 City
>>>> Road, London, EC1V 2NX, UK.
>>>> The views expressed in this email are those of the author and not
>>>> necessarily those of Funky Android Limited, it's associates, or it's
>>>> subsidiaries.
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
>>>> For additional commands, e-mail: dev-h...@struts.apache.org
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>> --
>> ======
>> Funky Android Limited is registered in England & Wales with the company
>> number 6741909. The registered head office is Kemp House, 152-160 City
>> Road, London, EC1V 2NX, UK.
>> The views expressed in this email are those of the author and not
>> necessarily those of Funky Android Limited, it's associates, or it's
>> subsidiaries.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
>> For additional commands, e-mail: dev-h...@struts.apache.org
>>
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
