Thanks! One more thing, is there any way to see (in detail) where tests are failing?
>-----Original Message----- >From: Wes Wannemacher [mailto:w...@wantii.com] >Sent: Tuesday, August 25, 2009 2:07 PM >To: Struts Developers List >Subject: Re: 2.1.8? > >Don't worry, we've all been there, I'm just happy to see that you want >to help out! > >-Wes > >On Tue, Aug 25, 2009 at 2:06 PM, Security >Management<list-subscripti...@secmgmt.com> wrote: >> OK, I'll take a stab at it, and if I get stuck, let the list know. > I'm >> trying to learn as I go, so it might take awhile... >> >>>-----Original Message----- >>>From: Wes Wannemacher [mailto:w...@wantii.com] >>>Sent: Tuesday, August 25, 2009 2:01 PM >>>To: Struts Developers List >>>Subject: Re: 2.1.8? >>> >>>I could be wrong, but when I first looked at this, I remembered a time >>>when maybe this plugin didn't take OGNL parameters? If that's the >>>case, this is probably just a remnant. You might want to switch around >>>the logic a little bit in your patch so that height/weight can be set >>>as OGNL params, and then you pull the values out as Longs when you set >>>them on the rendered chart... (or however you want to do it). >>> >>>You can probably check your new patch by adding a getMyHeight and >>>getMyWidth to an action and see if you can use them as OGNL properties >>>to set on the result (i.e. - >>> >>><param name="height">${myHeight}</param> >>> >>>I can't remember all of the conversion rules, but I'm pretty sure that >>>test was added when the params were made OGNL aware. >>> >>>-Wes >>> >>>On Tue, Aug 25, 2009 at 1:47 PM, Security >>>Management<list-subscripti...@secmgmt.com> wrote: >>>> OK, going through the tests for the jfreechart plugin, I see this: >>>> >>>> result.setHeight("${myHeight}"); >>>> result.setWidth("${myWidth}"); >>>> >>>> ValueStack stack = ActionContext.getContext().getValueStack(); >>>> stack.set("myHeight", 250); >>>> stack.set("myWidth", 150); >>>> >>>> I get that it's testing that the result is picking the values up off >>>of the >>>> value stack. >>>> >>>> However, the methods in the plugin setWidth(Long x) take Longs, so >>>this does >>>> not even compile. >>>> >>>> How is that? >>>> >>>> >>>> -------------------------------------------------------------------- >- >>>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>>> For additional commands, e-mail: dev-h...@struts.apache.org >>>> >>>> >>> >>> >>> >>>-- >>>Wes Wannemacher >>> >>>Head Engineer, WanTii, Inc. >>>Need Training? Struts, Spring, Maven, Tomcat... >>>Ask me for a quote! >>> >>>--------------------------------------------------------------------- >>>To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>>For additional commands, e-mail: dev-h...@struts.apache.org >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >> For additional commands, e-mail: dev-h...@struts.apache.org >> >> > > > >-- >Wes Wannemacher > >Head Engineer, WanTii, Inc. >Need Training? Struts, Spring, Maven, Tomcat... >Ask me for a quote! > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >For additional commands, e-mail: dev-h...@struts.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
