Does anyone have input on this?

So far I have been cleaning up the white space.

Any line wraps are the emails fault for the next 2 lines
Given: <!-- S --><s:fielderror fieldName="ledger.foo" /><s:textfield
name="ledger.foo"></s:textfield><!-- E -->
Produces: <!-- S --><ul id="ledger_" class="errorMessage"><li><span>foo is
required</span></li></ul><input type="text" name="ledger.foo" value=""
id="ledger_ledger_foo"/><!-- E -->

vs.

  Addr     0 1  2 3  4 5  6 7  8 9  A B  C D  E F 0 2 4 6 8 A C E
--------  ---- ---- ---- ---- ---- ---- ---- ---- ----------------
00000000  3c21 2d2d 2053 202d 2d3e 2020 2020 2020 <!-- S -->
00000010  2020 2020 2020 2020 2020 2020 2020 3c75               <u
00000020  6c20 2020 2020 2020 2020 2020 2020 2020 l
00000030  2020 2020 2020 2020 2020 2020 2020 2020
00000040  2069 643d 226c 6564 6765 725f 2220 2020  id="ledger_"
00000050  2020 2020 2020 2020 2020 2020 2020 2020
00000060  2020 2020 2020 2020 2020 2020 2063 6c61              cla
00000070  7373 3d22 6572 726f 724d 6573 7361 6765 ss="errorMessage
00000080  2220 2020 2020 2020 2020 2020 2020 2020 "
00000090  2020 2020 2020 2020 2020 2020 203e 0a20              >.
000000a0  2020 2020 2020 2020 2020 2020 2020 2020
000000b0  2020 2020 2020 203c 6c69 3e3c 7370 616e        <li><span
000000c0  3e66 6f6f 2069 7320 7265 7175 6972 6564 >foo is required
000000d0  3c2f 7370 616e 3e3c 2f6c 693e 0a20 2020 </span></li>.
000000e0  2020 2020 203c 2f75 6c3e 0a3c 696e 7075      </ul>.<inpu
000000f0  7420 7479 7065 3d22 7465 7874 2220 6e61 t type="text" na
00000100  6d65 3d22 6c65 6467 6572 2e66 6f6f 2220 me="ledger.foo"
00000110  7661 6c75 653d 2222 2069 643d 226c 6564 value="" id="led
00000120  6765 725f 6c65 6467 6572 5f66 6f6f 222f ger_ledger_foo"/
00000130  3e3c 212d 2d20 4520 2d2d 3e             ><!-- E -->

The only question I have so far is about the id generation. What is it? Why is
it? Compare it to the textfield id generation. Every invocation of the
fielderror tag produces a ul with the same id value, which is bad.

Changes to the id logic, could / would break existing DOM reliance.

-Jason 

--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to