Hi Christoph, thanks for the code review and fixes.
I already added a basic plugin documentation: https://cwiki.apache.org/confluence/display/WW/Bean+Validation+Plugin May we should link from the validation site to the plugin documentation. Do you already have a confluence account? Johannes ################################################# web: http://www.jgeppert.com twitter: http://twitter.com/jogep 2015-06-12 10:57 GMT+02:00 Christoph Nenning <christoph.nenn...@lex-com.net> : > > From: Johannes Geppert <jo...@apache.org> > > To: Struts Developers List <dev@struts.apache.org>, > > Date: 27.05.2015 21:18 > > Subject: Re: Bean Validation Plugin in 2.5 > > > > Just pushed first version of new bean validation plugin. > > In general it is based on Umesh works, but I renamed some thinks and > made > > some small improvements. > > Also I added some first basic test cases. Would be nice if someone likes > to > > try the new bean validation plugin. > > > > Next step is preparing a example in the showcase app. > > > > Johannes > > > > ################################################# > > web: http://www.jgeppert.com > > twitter: http://twitter.com/jogep > > > > Hi, > > > finally I had some time to review the plugin. Looks good to me! Good work > Umesh and Johannes. I pushed some minor fixes, like typos in javadoc and > logging, added testcase, fixed generics related warnings (that is hard > with the JSR API ;) ). A maybe more intresting change I made is to use > ObjectFactory instead of Class.forName(). > > > We should add this to docs, maybe put it on this page (or a sub page): > http://struts.apache.org/docs/validation.html > > How can I edit it? > Do I need to checkout a SVN repo? > > > Regards, > Christoph > > This Email was scanned by Sophos Anti Virus >
