Github user wolpi commented on the pull request:
https://github.com/apache/struts/pull/50#issuecomment-142507218
> It make struts more robust.
When LocalizedTextUtil is used as intended and supported it is already
robust :wink:
> It doesn't increases maintenance burden
Well, this small patch itself does not. But the idea that struts code
should work even when no ValueStack is available. There are surley many more
places in the code base where such null checks are necessary to really support
Util classes outside of struts context. And the maintanance burden comes over
time. Even when your use case would work right now, with every change any
struts developer does, or external contributers are doing, they must remember
to make their changes working even outside of struts context.
Or put it another way: LocalizedTextUtil is not part of public API. It is a
struts internal utility.
What acutally is your use case? Can't you use java resource bundle API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
