Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/60#issuecomment-160655820
For struts 2.3 I still got an old app with tiles2 which does some custom
stuff and which has issues with these changes.
* `tiles-servlet-wildcard` depends on `spring-web`. That causes spring to
be pulled in to all apps that use `struts-tiles-pluign`. Due to this I would
prefer wildcard support could be optional
* in `TilesContainerFactory.createContainerFactory()` it is necessary for
me to register `tilesContainer` in `servletContext`. Can be done like this,
would you mind adding this to `StrutsTilesContainerFactory`?
```
@Override
protected BasicTilesContainer instantiateContainer(TilesApplicationContext
applicationContext) {
CachingTilesContainer tilesContainer = new CachingTilesContainer();
ServletContext servletContext = (ServletContext)
applicationContext.getContext();
ServletUtil.setContainer(servletContext, tilesContainer);
return tilesContainer;
}
```
* in `StrutsTilesContainerFactory.getSourceURLs()` these two resource
patterns are used: `/WEB-INF/**/tiles*.xml` and
`classpath*:META-INF/**/tiles*.xml`. The 2nd one causes an exception in
WebSphere with IBM JDK. Would be nice if we could make this configurable. The
exception is `Caused by: java.net.MalformedURLException: SRVE0238E: Resource
paths should have a leading slash`
Currently I have created my own `TilesListener`, `TilesInitializer` and
`TilesContainerFactory`. With the above changes I could avoid that and just
stick to `StrutsTilesListener`.
Two minor things I noticed in showcase app:
* It logs this message: `WARN (freemarker.jsp:75) - Custom EL functions
won't be loaded because no ObjectWarpper was specified .` So it may be that
`tiles-el` along with `tiles-freemarker` are not working?
* css layout seems to be broken in firefox (surely not related to this PR,
looks good in chrome and ie11, is fixed in master branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
