Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50153311
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className,
Location loc) {
}
params.putAll(resultParams);
- ResultConfig resultConfig = new
ResultConfig.Builder(resultName, resultClass)
- .addParams(params)
- .location(DomHelper.getLocationObject(element))
- .build();
- results.put(resultConfig.getName(), resultConfig);
+ Set<String> resultNamesSet;
+ if (",".equals(resultName.trim())) {
+ resultNamesSet = new HashSet<>(1);
+ resultNamesSet.add(resultName);
--- End diff --
You mean like this?
Set<String> resultNamesSet =
TextParseUtil.commaDelimitedStringToSet(resultName);
if (resultNamesSet.isEmpty()) {
resultNamesSet.add(resultName);
}
Yeah, looks a bit cleaner to me. I'll change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
