I have retested this, and although it seems to work, it now messes with my interceptors, ie they do not get called when I add the STORE to my action.
The RETRIEVE seems to be OK. I have copied the objects from this patch https://git-wip-us.apache.org/repos/asf?p=struts.git;h=857195c com.opensymphony.xwork2.DefaultActionInvocation org.apache.struts2.interceptor.MessageStoreInterceptor org.apache.struts2.interceptor.MessageStorePreResultListener to my source, were there any more changes? This is my stack, where it does not call MyPrepareInterceptor : <interceptor-stack name="MyStack"> .... <interceptor-ref name="params" /> <interceptor-ref name="conversionError" /> <!-- It does not call this now and anything after it --> <interceptor-ref name="MyPrepareInterceptor"> <param name="excludeMethods">cancel*</param> </interceptor-ref> .... </interceptors> <!-- Save messages --> <interceptor-ref name="store"> <param name="operationMode">STORE</param> </interceptor-ref> Any ideas? Cheers Greg On 11 February 2016 at 07:23, Lukasz Lenart <[email protected]> wrote: > 2016-02-08 13:50 GMT+01:00 Lukasz Lenart <[email protected]>: > > 2016-02-08 13:44 GMT+01:00 Greg Huber <[email protected]>: > >> I was dong some more testing and noticed that my message store > interceptor > >> messages have stopped working. > >> > >> There is a check in the > >> org.apache.struts2.interceptor.MessageStoreInterceptor to see if the > >> response has been committed, and if it is skip the messages processing. > >> > >> boolean isCommitted = ServletActionContext.getResponse().isCommitted(); > >> > >> LOG.debug("Response was already committed, cannot store messages!"); > >> > >> I do not think I am committing any struts stuff so was wondering if > >> anything has changed that would? > > > > Yes, it's a side effect of this change [1] but I already refactored > > the code [2] and now it works even with redirects - is it worth to > > backport it to 2.3.25? > > > > [1] https://issues.apache.org/jira/browse/WW-4600 > > [2] https://issues.apache.org/jira/browse/WW-4605 > > I have ported the same solution to 2.3.25, I hope it won't break anything > :) > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
