Github user yasserzamani commented on a diff in the pull request:

    https://github.com/apache/struts/pull/118#discussion_r100774641
  
    --- Diff: 
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java 
---
    @@ -160,7 +160,20 @@ private void copyStack(ActionInvocation invocation, 
CompoundRoot root) {
             Map<String, Object> ctxMap = 
invocation.getInvocationContext().getContextMap();
             for (Object object : list) {
                 if (shouldCopy(object)) {
    -                reflectionProvider.copy(object, invocation.getAction(), 
ctxMap, prepareExcludes(), includes);
    +                String actionConfigClassName = 
invocation.getProxy().getConfig().getClassName();
    +                Object action = invocation.getAction();
    +                if 
(action.getClass().getName().equals(actionConfigClassName))
    +                    reflectionProvider.copy(object, action, ctxMap, 
prepareExcludes(), includes, null);
    +                else {     //only setting properties defined in the given 
config class e.g. to skip proxy properties (WW-4105)
    +                    Class <?> editable;
    +                    try {
    +                        editable =  Class.forName(actionConfigClassName);
    +                    } catch (ClassNotFoundException e) {
    +                        LOG.warn("An unexpected state. This may be due to 
a bug. Please report this: ClassNotFoundException" + actionConfigClassName);
    --- End diff --
    
    I also fixed Indentations to use 4 spaces instead of tab, both in my 
current PRs and my eclipse. Sorry, I'll be more careful about formatting in my 
next works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to