I have a question about the pull request. In the interface LocaleProviderFactory, there's only a method called createLocaleProvider.
Does this mean that there's supposed to be a seperate instance of LocaleProvider on every single place this is used? (I know you could technicaly implement the interface and provide the exact same provider, but seeing the method is named create and not get (or obtain or something) it sounds to me that it's the intention to return a new instance every single time) What is the reason that this object (the LocaleProvider) should not be reused? Is it because ActionSupport still implements LocaleProvider? This doesn't realy prevent that an ActionSupport instance gets used as LocaleProvider? Please excuse my ignorance if this is a dumb question. Regards, Stefaan Dutry (sdutry) 2017-03-15 18:54 GMT+01:00 Lukasz Lenart <[email protected]>: > If no objections I will merge this PR [1] tomorrow > > [1] https://github.com/apache/struts/pull/122 > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
