I think this is the last part of the Text Localisation puzzle :) This PR introduces a dedicated interface - TextProviderFactory with a default implementation to allow create custom TextProviders but to avoid problems with multiple dependencies as it was reported by Christian.
Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2017-03-17 8:12 GMT+01:00 lukaszlenart <[email protected]>: > GitHub user lukaszlenart opened a pull request: > > https://github.com/apache/struts/pull/123 > > WW-4756: Introduce TextFactoryProvider > > This PR introduces a dedicated interface `TextProviderFactory` with a > default implementation to allow easier further customisations by users. > > Implements [WW-4756](https://issues.apache.org/jira/browse/WW-4756) > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/lukaszlenart/struts text-provider-factory > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/struts/pull/123.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #123 > > ---- > commit 4f46f151844bcef39cd631a6fb1cd781fd34224a > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-16T13:39:06Z > > Adds missing class header with license > > commit 9376bb0ca16595cac0a1d03fb7b4fa55ab66a8f3 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-16T13:43:07Z > > Renames TextProviderFactory into StrutsTextProviderFactory > > commit 54974223fa1f6a66d8c1d61b7b18c94ef5c50386 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-16T13:55:35Z > > Extracts TextProviderFactory interface > > commit 3b73544a8ff5e9d96885147bf25c7c2598ac6b21 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T06:49:33Z > > Uses existing instance instead of creating a new one > > commit 207ac1774439f72cdfab32c45a3c59ba5a972899 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T06:51:12Z > > Defines proper interfaces and default implementation in configuration > > commit 16d1d60ed826c639d2298b77b27c184d9684f21c > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T06:51:57Z > > Uses dedicated logger instead the one from parent class > > commit 944b1a2303536023973456d6685f9ab86a775cb0 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T06:59:50Z > > Injects proper dependencies into tag > > commit ee6c927db6663741c3d0179e16687704359ea40c > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T07:02:24Z > > Drops unavailable dependency > > commit c039685cf946f5e9864ae175a14f3ccdc0edbe59 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T07:02:52Z > > Moves bean into same area are other releated to it beans > > commit 132829cc244d60692e3547c5c40b72e29eea1a9e > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T07:03:28Z > > Defines bean in test configuration > > commit e8a598c7bc83752f488ad4ccccd0d11a64df3f03 > Author: Lukasz Lenart <[email protected]> > Date: 2017-03-17T07:03:48Z > > Updates test to use the new injectable factory > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
