Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/135#discussion_r115664014
  
    --- Diff: 
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
    @@ -0,0 +1,89 @@
    +/*
    + * Copyright 2017 The Apache Software Foundation.
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package com.opensymphony.xwork2.spring;
    +
    +import com.opensymphony.xwork2.util.ClassLoaderUtil;
    +import org.apache.commons.lang3.reflect.MethodUtils;
    +
    +import java.lang.reflect.Proxy;
    +
    +/**
    + * <code>SpringUtils</code>
    + * <p>
    + * Various utility methods dealing with spring framework
    + * </p>
    + *
    + */
    +public class SpringUtils {
    --- End diff --
    
    `SpringUtils` doesn't sound good but I have no better name for now. Also 
it's the only case we have now so we can always refactor this code and 
introduce an interface with few implementation latter on.
    
    For future reference: it would be good to have a `ProxyAware` interface in 
the `core` with a default implementation (that does nothing) and then in the 
Spring Plugin provide a real implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to