>Hello Yasser (and developers).

Hello James,

FYI it seems we at Struts team also want to fix issues reported at 
https://lgtm.com/blog/apache_struts_double_evaluations

Please also see inline below regarding Jira issues:

>4999 - Lukasz indicated he was able to reproduce it.  Can anyone else reproduce
>it in 2.5.21-SNAPSHOT (and attach a reproducer to the Jira) ?

Yes and PR#357 proposed :)

>5011 - Yasser has a proposed fix awaiting approval/merge.  :)

Fixed (e.g. merged)

>5027 - Can anyone else reproduce it in 2.5.21-SNAPSHOT (and attach a
>reproducer to the Jira) ?

Closed as duplicate - I don't think it's a Struts issue. Please see my close 
comment there.

>5031 - Produces warning in JDK11 (no impact on functionality).  Should it be
>addressed for 2.5.21, future 2.5.x or 2.6.x ?

I think we should analyze failed Struts tests with --illegal-access=deny JVM 
option then if they weren't complicated and were backward-compatible to solve, 
then it's nice to fix them for 2.5.21 but I guess they aren't.

>5033 - Dependency version upgrades, awaiting review for approval/merge.

I'm not sure if this issue is OK (Lukasz?)  - AFAIK Jira needs separate issue 
for each dependency upgrade for clear output on release doc.

>5034 - Small enhancement, awaiting review for approval/merge.

(waiting for 2.6 equal PR) 

Regards.

Reply via email to