JCgH4164838Gh792C124B5 commented on issue #404: URL: https://github.com/apache/struts/pull/404#issuecomment-616271172
Hello Apache Struts Team. This is a very basic PR (it was just a bit-of-a-pain to isolate the issue). Basically, the default locale behaviour for some date validation tests differs for JDK7/8 compared to newer JDKs (such as JDK 11). When running the tests in a non-US locale some date validation unit tests can fail, causing the Struts 2 Core build to fail. The proposed improvement is to ensure the affected unit tests utilize the expected US locale to process the MM/DD/CCYY formats as expected. Now they should work as intended on JDK7+, even if the base system's locale is not US. **Note**: Windows 10 with JDK 11 (OpenJDK and Oracle) still appear to fail during a full Struts 2 build due to an apache-rat-plugin failure. I was forced to locally use "-Drat.skip=true" to verify the full build with JDK11, but the Core build by itself passed fine). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
