Yes looks good. Thanks! Also there is a trivial issue (https://issues.apache.org/jira/browse/WW-5087) which I can bring to 2.5.x.
Regards. On 9/13/2020 3:38 PM, Lukasz Lenart wrote: > I notice a few important fixes have pushed into struts-2-5-x branch - > OSGi and empty files upload. Maybe I will cancel this build, prepare a > new one to include those fixes, wdyt? > > śr., 26 sie 2020 o 08:47 Lukasz Lenart <lukaszlen...@apache.org> napisał(a): >> >> pon., 24 sie 2020 o 00:45 James Chaplin <jchap...@apache.org> napisał(a): >>> Hello Lukasz and Markus. >>> >>> Thanks Lukasz, for the latest build. :) >>> >>> The 2.5.24 test build seems OK to me. >>> >>> The date/time values for the contents of the .zip appear normal (so the fix >>> for the build issue of 2.5.23 seems to still be working). I also did a >>> quick run-through of both 2.5.24 Showcase applications (in JRE 7 / Tomcat >>> 8.5.x) and found no issues, either. >>> >>> With respect to Markus' comments about the library versions, I think the >>> four mentioned (commons-collections-4, commons-io-2.7, commons-lang-3.9, >>> log4j-2.13.3) all require Java 8 to run. Since 2.5.x still supports JDK 7, >>> the official builds should probably stick to the older library revisions >>> (for now). >>> >>> As Markus' said, developers running on JDK 8+ can replace library JARs from >>> the distribution with newer versions during their builds if they desire, >>> but they might encounter issues not seen with the older versions. >> >> Thanks James for the clarification, I think we don't have any blockers >> and I can call for a vote :) >> >> >> Regards >> -- >> Łukasz >> + 48 606 323 122 http://www.lenart.org.pl/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
