Hi Łukasz.
Thanks for clarifying the question about SMI and the DTD. :)
Here are some possible additions for the default exclusion packages:
com.ibm.websphere.,
org.apache.geronimo.,
org.apache.openejb.,
org.apache.tomee.,
org.eclipse.jetty.,
org.mortbay.jetty.,
org.glassfish.,
org.jboss.as.,
org.wildfly., (a more general version of one of the recent additions)
weblogic.,
I do not think any of those would cause issues, but no guarantees.
Developers can always modify the exclusion packages they are using, if needed,
anyway.
Regards,
James.
On 2020/11/23 06:50:35, Lukasz Lenart <lukaszlen...@apache.org> wrote:
> pon., 23 lis 2020 o 04:40 James Chaplin <jchap...@apache.org> napisał(a):
> >
> > Hi Łukasz.
> >
> > Thanks for your work on, and putting together, the 2.5.26 test build.
> >
> > I downloaded the Struts 2.5.26 test build and ran the Struts Showcase
> > and Struts Rest Showcase applications locally. All the interaction for
> > both applications seemed to work fine with the 2.5.26 test build (using
> > Tomcat 8.5, Java 7).
> >
> > After reviewing the diff/changes in the 2.5.26 build, I did have a
> > couple of quick questions to ask:
> > 1) A struts-default.xml change removed having SMI
> > (strict-method-invocation) enabled by default. Was that intentional ? If
> > not, it seems that maybe SMI should continue to be true by default, since
> > it could change expected behaviour, otherwise.
>
> By DTD, "strict-method-invocation" is set to "true" by default, but
> you are right, this can be misleading and users can do not understand
> why/how "strict-method-invocation" is set to "true" - I will rollback
> that change.
>
> > 2) Some new default excluded packages were added. Would there be any
> > consideration/value in adding some more at the same time (for this release)
> > ? I might have some suggestions, based on the ones that were added.
>
> Sure, feel free to post your findings.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
