Yet I think we should update DefaultExcludedPatternsChecker and
exclude `action:` by default.

I did try that, but ParametersInterceptor then swaps the ParametersInterceptor:isAccepted 
to an ParametersInterceptor:isExcluded message🙁.  Would need to add an ignored somewhere 
or something like add an islog() to class ExcludedPatternsChecker.IsExcluded (or 
AcceptedPatternsChecker.IsAccepted) for downstream handling in ParametersInterceptor, but 
any mods for this would not be efficient/simple as would need to workout which exclusion 
is from the setAdditionalExcludePatterns("^(action|method):.*") ie system 
level, and to log(false);.


It should be possible to filter out such parameters, your action must
implement `ParameterNameAware` interface and then it can control which
parameters can be accepted.
Also you can define `struts.additional.excludedPatterns` as
`action:.*` and that also should solve the problem.

Seems all my actions produce the log warning, I only use default processing 
logic ie extend ActionSupport. using struts.additional.excludedPatterns would 
just swap the warning.


On 21/01/2021 07:25, Lukasz Lenart wrote:
czw., 21 sty 2021 o 07:44 Greg Huber <gregh3...@gmail.com> napisaƂ(a):
Looking more into it, the DMI stuff with respect to the
ParametersInterceptor is work in progress,  I tried various ways to
suppress the warnings, but something extra needs to be done, ie the
parameter 'action:myAction!save' should not really be considered a
bean/ognl parameter, more system level as its associated with the page
submission mechanism.
It should be possible to filter out such parameters, your action must
implement `ParameterNameAware` interface and then it can control which
parameters can be accepted.
Also you can define `struts.additional.excludedPatterns` as
`action:.*` and that also should solve the problem.

Yet I think we should update DefaultExcludedPatternsChecker and
exclude `action:` by default.


Regards

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to