Hi Lukasz.

     Using the 2.5.27 test build zip artifacts, I tried out the Showcase 
application.  I did not notice any issues with the 2.5.27 Showcase 
interactively, as things seemed to work OK (similar to previous releases).

     However, looking at the console logs when running it, there were a bunch 
of warn-level outputs mentioning the anchor (a.ftl and a-close.ftl), for the 
first access of certain features in the Showcase:

"template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - 
Rendering tag /template/simple/a.ftl out of Action scope, accessing directly 
JSPs is not recommended! Please read 
https://struts.apache.org/security/#never-expose-jsp-files-directly";
"template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - 
Rendering tag /template/simple/a-close.ftl out of Action scope, accessing 
directly JSPs is not recommended! Please read 
https://struts.apache.org/security/#never-expose-jsp-files-directly";

     I noticed those for the initial main page load of the Showcase, as well as 
the Person Manager and CRUD examples.  It seemed to only occur the 1st time 
they were accessed within a given browser session.

     It is entirely possible that those are valid warnings (showing up via the 
change in FreemarkerTemplateEngine in 2.5.27), due to the structure of the 
Showcase and some of its examples, but I could not confirm that.  I wanted to 
advise of what I saw, in case there might be a weird corner-case for "s:a" 
anchor tag processing that could produce unexpected warnings with 2.5.27.

     If anyone has tried testing out an application with 2.5.27 which uses 
"s:a" tags, please let the dev list know if you see similar log warnings (and 
are not expecting to). 

Regards,

     James.


On 2021/10/26 12:48:29, Lukasz Lenart <lukaszlen...@apache.org> wrote: 
> I assume there is no objection to starting the Vote.
> 
> wt., 19 paź 2021 o 12:26 Greg Huber <gregh3...@gmail.com> napisał(a):
> >
> > They seem to download when I use maven-dependency-plugin.
> >
> > [INFO]
> > [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
> > (copy-dependencies) @ events ---
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > (4.3 kB at 53 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > (9.8 kB at 656 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > (12 kB at 845 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > (3.1 kB at 220 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > (2.9 kB at 208 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
> > [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
> > ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
> > ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
> > ConflictIdSorter.conflictIdCount=93,
> > ConflictIdSorter.conflictIdCycleCount=0,
> > ConflictResolver.totalTime=1514331,
> > ConflictResolver.conflictItemCount=194,
> > DefaultDependencyCollector.collectTime=267604268,
> > DefaultDependencyCollector.transformTime=2378444}
> >
> >
> > I have scanned the .m2 struts folder,  and their is nothing in the
> > struts2 poms using struts1
> >
> >
> > On 19/10/2021 10:29, Lukasz Lenart wrote:
> > > wt., 19 paź 2021 o 11:20 Greg Huber <gregh3...@gmail.com> napisał(a):
> > >> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> > >> stuff? If I remove my repo above it still downloads them.
> > >>
> > >> struts-core, struts-master, struts-parent etc
> > >>
> > >> Maybe a maven thing?
> > > Some plugins can have transient dependencies on the Apache Struts 1,
> > > use `mvn dependency:tree` to track them down. It could also be
> > > Freemarker, Tiles or Spring.
> > >
> > >
> > > Regards
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> > For additional commands, e-mail: dev-h...@struts.apache.org
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to