Thanks :) I've created a PR to address the mismatch between the code and tests https://github.com/apache/struts/pull/529
niedz., 6 lut 2022 o 12:21 Greg Huber <gregh3...@gmail.com> napisał(a): > > ok, thought it was a typo (although I have few with aa). Thought I > would mention it. > > Been through most screens/tests and the rc looks good for me. > > Good job.😁 > > On 06/02/2022 10:56, Lukasz Lenart wrote: > > Thanks Greg, very good catch :) > > > > The problem is that the tag is using DateTimeFormatter [1] (a new API > > introduced in JDK 8), but the unit tests are using SimpleDateFormat > > [2] (an old API) and both of these classes are using slightly > > different patterns [3]. The change has been made to support Java 8 > > LocalDate [4] and others introduced in JDK8, yet the SimpleDateFormat > > supports only java.util.Date. > > > > I added a note to the ticket and I will extend the migration guide. > > > > [1] > > https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html > > [2] > > https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html > > [3] > > https://stackoverflow.com/questions/42903391/convert-simpledateformat-to-datetimeformatter > > [4] https://issues.apache.org/jira/browse/WW-5016 > > > > > > Regards > > -- > > Łukasz > > + 48 606 323 122 http://www.lenart.org.pl/ > > > > pt., 4 lut 2022 o 11:18 Greg Huber <gregh3...@gmail.com> napisał(a): > >> From the Struts has detected an unhandled exception: > >> > >> > >> *Messages*: > >> > >> 1. Too many pattern letters: a > >> 2. JSPException including path '/WEB-INF/jsp/my.jsp'. > >> 3. ....... > >> > >> *File*: java/time/format/DateTimeFormatterBuilder.java > >> *Line number*: 1,774 > >> > >> > >> although if I test 'EEEE MMMM dd, hh:mm aa' using SimpleDateFormat it works > >> > >> Tuesday February 22, 12:00 PM > >> > >> > >> > >> -------- Forwarded Message -------- > >> Subject: Re: [TEST] Struts 2 ver. 6.0.0-RC2 test build is ready > >> Date: Fri, 4 Feb 2022 09:30:47 +0000 > >> From: Greg Huber <gregh3...@gmail.com> > >> To: dev@struts.apache.org > >> > >> > >> > >> I have noticed that the date format only now wants a single a. I get an > >> error when using two. > >> > >> <s:date name="#my.myDate" format="EEEE MMMM dd, hh:mm aa" /> error > >> > >> <s:date name="#my.myDate" format="EEEE MMMM dd, hh:mm a" /> works > >> > >> Checking previous commits it's always been aa ie two. > >> > >> On 29/01/2022 16:49, Lukasz Lenart wrote: > >>> Hello, > >>> > >>> This is a second RC of incoming Struts 6.x with tons of changes. > >>> Please take a time and test the bits - any help is appreciated. Please > >>> report any problems you will spot. > >>> > >>> Staging Maven repo > >>> https://repository.apache.org/content/groups/staging/ > >>> > >>> Standalone artifacts > >>> https://dist.apache.org/repos/dist/dev/struts/6.0.0-RC2/ > >>> > >>> Release notes > >>> https://cwiki.apache.org/confluence/display/WW/Version+Notes+6.0.0 > >>> > >>> > >>> Kind regards > >>> -- > >>> Łukasz > >>> + 48 606 323 122 http://www.lenart.org.pl/ > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > >>> For additional commands, e-mail: dev-h...@struts.apache.org > >>> > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > > For additional commands, e-mail: dev-h...@struts.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
