yasserzamani commented on code in PR #164: URL: https://github.com/apache/struts-examples/pull/164#discussion_r950819926
########## jasperreports/pom.xml: ########## @@ -0,0 +1,87 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 + http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>struts-examples</artifactId> + <groupId>org.apache.struts</groupId> + <version>1.1.0</version> + </parent> + + <artifactId>jasperreports</artifactId> + <packaging>war</packaging> + + <name>JasperReports Tutorial</name> + <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url> + <properties> + <spring.platformVersion>5.3.20</spring.platformVersion> + <jasperreports.version>6.20.0</jasperreports.version> + </properties> + + <dependencyManagement> + <dependencies> + <dependency> + <groupId>org.springframework</groupId> + <artifactId>spring-framework-bom</artifactId> Review Comment: Firstly thank you very much for your PR! Just IMHO add spring as dependency is too much for this sample I think. If you want then you might delete all spring stuff from your sample. Instead, in the beginning of action method, simply check if corresponding .jasper file exists or not. If exists then do nothing otherwise compile the .jrxml file and create the needed .jasper file. This approach will have two benefits: 1. User can update and deploy a new report design without restarting app i.e. by deleting .jasper and .jrxml files and copying new .jrxml file. 2. The sample will be less complex and also will have less not required dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
