Looking at it in more depth, I think we need to leave as much code as possible in the attic, including the autotag stuff. Keep only the parts to make it work, and update the tag classes manually. Having to maintain classes to generate the tag classes is pointless (might as well update them directly). If we need to generate the tld we can use the struts tld processor.
This means we don't need all of the velocity code, support classes etc and should reduce the plugin packages also. I will play around with it to see what we can loose, so we only have the bare minimum. On Sun, 9 Oct 2022 at 10:52, Greg Huber <gregh3...@gmail.com> wrote: > Or better, try to build the tags (whatever the maven-autotag-pluging > did) on the plugin build? > > On 09/10/2022 10:28, Greg Huber wrote: > > The reason why the taglibs were missing, they are generated by tiles > > auto tag > > > > https://tiles.apache.org/tiles-autotag/ > > > > Tiles-3 introduces a f Autotag Project, a project that automatically > > generates tags (or tag-like) artifact from a common template code for > > a range of templating languages. Today JSP tags, Freemarker directive > > models and Velocity directives are generated from a common template > > models. > > > > Do we use Freemarker directive models and Velocity directives? > > > > Maybe we don't need the autotag in the plugin as we have the tag > > classes now? > > > > On 06/10/2022 14:05, Lukasz Lenart wrote: > >> I have prepared a PR to copy Tiles code base into the Tile plugin - > >> just copied what is needed by the plugin. I would like to merge it > >> after releasing 6.1.0 > >> > >> https://github.com/apache/struts/pull/608 > >> > >> > >> Regards > >> -- > >> Łukasz > >> + 48 606 323 122 http://www.lenart.org.pl/ > >> > >> wt., 9 sie 2022 o 16:43 Antonio Petrelli <antonio.petre...@gmail.com> > >> napisał(a): >
