adamantal opened a new pull request #91: SUBMARINE-66. Improve TF config env JSON generator + tests URL: https://github.com/apache/submarine/pull/91 ### What is this PR for? * The goal is to update the TensorFlow config generation. Also some of the tests were doing some manual JSON thing which is not very maintainable - it is also changed to a more flexible one using jackson-databind ### What type of PR is it? * Refactoring | Test ### Todos * [ ] - Travis checks * [ ] - New tests should pass ### What is the Jira issue? * [SUBMARINE-66](https://issues.apache.org/jira/browse/SUBMARINE-66) ### How should this be tested? * Only the new UTs should pass. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? Yes * We should probably add jackson-module-jaxb-annotations? * Is there breaking changes for older versions? No * Does this needs documentation? No
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
