[
https://issues.apache.org/jira/browse/SUBMARINE-66?focusedWorklogId=341920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341920
]
ASF GitHub Bot logged work on SUBMARINE-66:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 13:49
Start Date: 12/Nov/19 13:49
Worklog Time Spent: 10m
Work Description: adamantal commented on pull request #91: SUBMARINE-66.
Improve TF config env JSON generator + tests
URL: https://github.com/apache/submarine/pull/91
### What is this PR for?
* The goal is to update the TensorFlow config generation. Also some of the
tests were doing some manual JSON thing which is not very maintainable - it is
also changed to a more flexible one using jackson-databind
### What type of PR is it?
* Refactoring | Test
### Todos
* [ ] - Travis checks
* [ ] - New tests should pass
### What is the Jira issue?
* [SUBMARINE-66](https://issues.apache.org/jira/browse/SUBMARINE-66)
### How should this be tested?
* Only the new UTs should pass.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? Yes
* We should probably add jackson-module-jaxb-annotations?
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341920)
Time Spent: 2.5h (was: 2h 20m)
> Improve TF config env JSON generator + tests
> --------------------------------------------
>
> Key: SUBMARINE-66
> URL: https://issues.apache.org/jira/browse/SUBMARINE-66
> Project: Apache Submarine
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Labels: pull-request-available
> Attachments: SUBMARINE-66.001.patch, SUBMARINE-66.002.patch,
> SUBMARINE-66.002.patch, SUBMARINE-66.003.patch, SUBMARINE-66.003.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.tensorflow.TensorFlowCommons#getTFConfigEnv
> generates a JSON of the TF_CONFIG environment variable.
> This code could be improved to use a JSON serializer instead of hand-crafting
> JSON data.
> The test class of this class also could be improved:
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.TestTFConfigGenerator
> In this class, there are some quite unreadable JSON strings, this could be
> refactored to be read out from a file instead.
> TestTFConfigGenerator has only one testcase and it's ugly, as we use very
> long strings to verify the JSON data produced matches our expected JSON.
> We should use JSON files instead of manually constructing Strings in tests,
> especially if they are very long.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
