This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 44e91dd  SUBMARINE-290. Update submainre DEFAULT_RUNTIME_CLASS
44e91dd is described below

commit 44e91ddf07b5b05e0428634e6fac4e12e8b0de06
Author: pingsutw <[email protected]>
AuthorDate: Tue Nov 12 18:33:00 2019 +0800

    SUBMARINE-290. Update submainre DEFAULT_RUNTIME_CLASS
    
    ### What is this PR for?
    After SUBMARINE-255 merged, we rename our runtimes to
    ```
     org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory
     org.apache.submarine.server.submitter.yarnservice.YarnServiceRuntimeFactory
    ```
    but default in SubmarineConfiguration still is
    `org.apache.submarine.runtimes.tony.TonyRuntimeFactory`
    we also need to update it.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-290
    
    ### How should this be tested?
    https://travis-ci.org/pingsutw/hadoop-submarine/builds/610793459
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: pingsutw <[email protected]>
    
    Closes #90 from pingsutw/SUBMARINE-290 and squashes the following commits:
    
    ecbc9c2 [pingsutw] SUBMARINE-290. Update submainre DEFAULT_RUNTIME_CLASS
---
 docs/helper/QuickStart.md                                           | 6 +++---
 .../submarine/commons/runtime/conf/SubmarineConfiguration.java      | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/helper/QuickStart.md b/docs/helper/QuickStart.md
index b7aa215..4507475 100644
--- a/docs/helper/QuickStart.md
+++ b/docs/helper/QuickStart.md
@@ -51,7 +51,7 @@ Once the applicable runtime is chosen and environment is 
ready, a `submarine.xml
 
 |Configuration Name | Description |
 |:---- |:---- |
-| `submarine.runtime.class` | 
"org.apache.submarine.runtimes.tony.TonyRuntimeFactory" or 
"org.apache.submarine.runtimes.yarnservice.YarnServiceRuntimeFactory" |
+| `submarine.runtime.class` | 
"org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory" or 
"org.apache.submarine.server.submitter.yarnservice.YarnServiceRuntimeFactory" |
 
 <br />
 
@@ -61,9 +61,9 @@ A sample `submarine.xml` is here:
 <configuration>
   <property>
     <name>submarine.runtime.class</name>
-    <value>org.apache.submarine.runtimes.tony.TonyRuntimeFactory</value>
+    
<value>org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory</value>
     <!-- Alternatively, you can use:
-    
<value>org.apache.submarine.runtimes.yarnservice.YarnServiceRuntimeFactory</value>
+    
<value>org.apache.submarine.server.submitter.yarnservice.YarnServiceRuntimeFactory</value>
     -->
   </property>
 </configuration>
diff --git 
a/submarine-commons/commons-runtime/src/main/java/org/apache/submarine/commons/runtime/conf/SubmarineConfiguration.java
 
b/submarine-commons/commons-runtime/src/main/java/org/apache/submarine/commons/runtime/conf/SubmarineConfiguration.java
index 9daefd6..b51446b 100644
--- 
a/submarine-commons/commons-runtime/src/main/java/org/apache/submarine/commons/runtime/conf/SubmarineConfiguration.java
+++ 
b/submarine-commons/commons-runtime/src/main/java/org/apache/submarine/commons/runtime/conf/SubmarineConfiguration.java
@@ -61,7 +61,7 @@ public class SubmarineConfiguration extends Configuration {
 
   public static final String RUNTIME_CLASS = PREFIX + "runtime.class";
   public static final String DEFAULT_RUNTIME_CLASS =
-      "org.apache.submarine.runtimes.tony.TonyRuntimeFactory";
+      "org.apache.submarine.server.submitter.yarn.YarnRuntimeFactory";
 
   public void setSubmarineRuntimeClass(String runtimeClass) {
     set(RUNTIME_CLASS, runtimeClass);


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to