yuanzac commented on a change in pull request #93: SUBMARINE-292. Merge
workbench server into submarine server
URL: https://github.com/apache/submarine/pull/93#discussion_r347189492
##########
File path:
submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
##########
@@ -94,7 +94,7 @@ public static SubmarineConfiguration getInstance() {
return conf;
}
- public static SubmarineConfiguration newInstance() {
+ private static SubmarineConfiguration newInstance() {
Review comment:
As every session can have its own configuration for user, so newInstance
should be public
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
